De-duplicate steps between chromium and chromium_trybot recipes

scripts/slave/recipes/chromium.py

Index: scripts/slave/recipes/chromium.py
diff --git a/scripts/slave/recipes/chromium.py b/scripts/slave/recipes/chromium.py
index de296de9ef89cb8c634868ee9c2f7a6877f1dee3..3699798590bc25cb1f4a04d786e9e00630dd9dc8 100644
--- a/scripts/slave/recipes/chromium.py
+++ b/scripts/slave/recipes/chromium.py
@@ -15,6 +15,7 @@ DEPS = [
   'properties',
   'python',
   'step_history',
+  'test_utils',

[agable, 2014/06/27 18:34:42]

I find it to be an anti-pattern for this recipe to depend on the test_utils
module now, even though it never calls api.test_utils.

[Paweł Hajdan Jr., 2014/06/27 18:58:22]

Suggestions how to change this are welcome. One way I can definitely do is add a
TODO to clean this up. I'm also happy to structure things some other way if you
have something specific in mind.

 ]
 
 
@@ -218,7 +219,7 @@ def GenSteps(api):
     steps.append(api.chromium_android.common_tests_setup_steps())
 
   if not bot_config.get('do_not_run_tests'):
-    test_steps = [t.run(api) for t in bot_config.get('tests', [])]
+    test_steps = [t.run(api, '') for t in bot_config.get('tests', [])]

[agable, 2014/06/27 18:34:42]

Why not have suffix='' as a default argument everywhere?

[Paweł Hajdan Jr., 2014/06/27 18:58:22]

I considered that, I somewhat prefer it to be explicit.

If it's a strong opinion, I'm happy to change.

     steps.extend(api.chromium.setup_tests(bot_type, test_steps))
 
   if (api.chromium.c.TARGET_PLATFORM == 'android' and