De-duplicate steps between chromium and chromium_trybot recipes

scripts/slave/recipes/chromium.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 DEPS = [
   'archive',
   'bot_update',
   'chromium',
   'chromium_android',
   'gclient',
   'isolate',
   'json',
   'path',
   'platform',
   'properties',
   'python',
   'step_history',
+  'test_utils',

[agable, 2014/06/27 18:34:42]

I find it to be an anti-pattern for this recipe to depend on the test_utils
module now, even though it never calls api.test_utils.

[Paweł Hajdan Jr., 2014/06/27 18:58:22]

Suggestions how to change this are welcome. One way I can definitely do is add a
TODO to clean this up. I'm also happy to structure things some other way if you
have something specific in mind.

 ]
 
 
 # Different types of builds this recipe can do.
 RECIPE_CONFIGS = {
   'chromeos_official': {
     'chromium_config': 'chromium_official',
     'chromium_apply_config': ['chromeos'],
     'gclient_config': 'chromium',
     'gclient_apply_config': ['chrome_internal'],
@@ skipping 183 matching lines @@
         extra_url_components=api.properties['mastername'],),
       build_revision=got_revision,
       # TODO(phajdan.jr): Move abort_on_failure to archive recipe module.
       abort_on_failure=True))
 
   if (api.chromium.c.TARGET_PLATFORM == 'android' and
       bot_type in ['tester', 'builder_tester']):
     steps.append(api.chromium_android.common_tests_setup_steps())
 
   if not bot_config.get('do_not_run_tests'):
-    test_steps = [t.run(api) for t in bot_config.get('tests', [])]
+    test_steps = [t.run(api, '') for t in bot_config.get('tests', [])]

[agable, 2014/06/27 18:34:42]

Why not have suffix='' as a default argument everywhere?

[Paweł Hajdan Jr., 2014/06/27 18:58:22]

I considered that, I somewhat prefer it to be explicit.

If it's a strong opinion, I'm happy to change.

     steps.extend(api.chromium.setup_tests(bot_type, test_steps))
 
   if (api.chromium.c.TARGET_PLATFORM == 'android' and
       bot_type in ['tester', 'builder_tester']):
     steps.append(api.chromium_android.common_tests_final_steps())
 
   # For non-trybot recipes we should know (seed) all steps in advance,
   # at the beginning of each build. Instead of yielding single steps
   # or groups of steps, yield all of them at the end.
   yield steps
@@ skipping 97 matching lines @@
                            buildername='Chromium Linux MSan',
                            parent_buildername='Chromium Linux MSan Builder') +
     api.platform('linux', 64) +
     api.override_step_data('read test spec', api.json.output({
       'Chromium Linux MSan': {
         'compile_targets': ['base_unittests'],
         'gtest_tests': ['base_unittests'],
       },
     }))
   )