Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339173002: Removed the redundant !this check (fix Clang's -Wundefined-bool-conversion warning) (Closed)

Created:
6 years, 6 months ago by Alexander Potapenko
Modified:
6 years, 6 months ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Removed the redundant !this check (fix Clang's -Wundefined-bool-conversion warning) BUG=381910 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
haraken
LGTM.
6 years, 6 months ago (2014-06-17 13:07:11 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 6 months ago (2014-06-17 13:15:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/339173002/1
6 years, 6 months ago (2014-06-17 13:16:47 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 15:04:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18090)
6 years, 6 months ago (2014-06-17 15:04:41 UTC) #5
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 6 months ago (2014-06-17 15:17:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/339173002/1
6 years, 6 months ago (2014-06-17 15:18:15 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 15:35:27 UTC) #8
Message was sent while issue was closed. 
Change committed as 176322

Powered by Google App Engine
This is Rietveld 408576698