Source/core/html/HTMLElement.cpp - Issue 339173002: Removed the redundant !this check (fix Clang's -Wundefined-bool-conversion warning)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 339173002: Removed the redundant !this check (fix Clang's -Wundefined-bool-conversion warning) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLElement.cpp

diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp

index 1a98cf035b19329dd366f97188a7a7072d8790bd..faf566ba5ffb14534f756106226b9abc697346b9 100644

--- a/Source/core/html/HTMLElement.cpp

+++ b/Source/core/html/HTMLElement.cpp

@@ -434,7 +434,7 @@ void HTMLElement::setOuterText(const String &text, ExceptionState& exceptionStat

newChild = Text::create(document(), text);

// textToFragment might cause mutation events.

- if (!this || !parentNode())

+ if (!parentNode())

exceptionState.throwDOMException(HierarchyRequestError, "The element has no parent.");

if (exceptionState.hadException())

« no previous file with comments | « no previous file | no next file » | no next file with comments »