Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 339153005: Show About in a window too. (Closed)

Created:
6 years, 6 months ago by michaelpg
Modified:
6 years, 6 months ago
Reviewers:
stevenjb, sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Show About in a window too. With --enable-settings-window, About should behave the same way Settings does. BUG=385496 R=stevenjb@chromium.org,sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278027

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/ui/chrome_pages.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/settings_window_manager_browsertest.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
michaelpg
6 years, 6 months ago (2014-06-17 19:42:18 UTC) #1
stevenjb
Cheers, lgtm.
6 years, 6 months ago (2014-06-17 19:57:43 UTC) #2
sky
LGTM
6 years, 6 months ago (2014-06-17 23:51:08 UTC) #3
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 6 months ago (2014-06-18 00:12:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/339153005/20001
6 years, 6 months ago (2014-06-18 00:14:00 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 10:56:02 UTC) #6
Message was sent while issue was closed.
Change committed as 278027

Powered by Google App Engine
This is Rietveld 408576698