chrome/browser/ui/chrome_pages.cc - Issue 339153005: Show About in a window too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 339153005: Show About in a window too. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/chrome_pages.cc

diff --git a/chrome/browser/ui/chrome_pages.cc b/chrome/browser/ui/chrome_pages.cc

index 3b8e4be59ea6c3e0ec030f1ef412160ff238e652..ad39d147039c56840a6a5f454531f72c68c4604d 100644

--- a/chrome/browser/ui/chrome_pages.cc

+++ b/chrome/browser/ui/chrome_pages.cc

@@ -288,6 +288,11 @@ void ShowImportDialog(Browser* browser) {

void ShowAboutChrome(Browser* browser) {

content::RecordAction(UserMetricsAction("AboutChrome"));

+ if (::switches::SettingsWindowEnabled()) {

+ SettingsWindowManager::GetInstance()->ShowChromePageForProfile(

+ browser->profile(), GURL(kChromeUIUberURL));

+ return;

+ }

NavigateParams params(

GetSingletonTabNavigateParams(browser, GURL(kChromeUIUberURL)));

params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;

« no previous file with comments | « no previous file | chrome/browser/ui/settings_window_manager_browsertest.cc » ('j') | no next file with comments »