src/ia32/lithium-codegen-ia32.cc - Issue 338963003: KeyedLoadIC should have same register spec as LoadIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Last comment response. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 8bb53f9d816a33fcb493aadd83a69817d94fd857..a918298eb191704fb5a4c51605f96f3ea01b0d45 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -3207,8 +3207,8 @@ Operand LCodeGen::BuildFastArrayOperand(

void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) {

ASSERT(ToRegister(instr->context()).is(esi));

- ASSERT(ToRegister(instr->object()).is(KeyedLoadIC::ReceiverRegister()));

- ASSERT(ToRegister(instr->key()).is(KeyedLoadIC::NameRegister()));

+ ASSERT(ToRegister(instr->object()).is(LoadIC::ReceiverRegister()));

+ ASSERT(ToRegister(instr->key()).is(LoadIC::NameRegister()));

Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();

CallCode(ic, RelocInfo::CODE_TARGET, instr);

« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »