Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 338963003: KeyedLoadIC should have same register spec as LoadIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Last comment response. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3189 matching lines...) Expand 10 before | Expand all | Expand 10 after
3200 return Operand(elements_pointer_reg, 3200 return Operand(elements_pointer_reg,
3201 ToRegister(key), 3201 ToRegister(key),
3202 scale_factor, 3202 scale_factor,
3203 base_offset); 3203 base_offset);
3204 } 3204 }
3205 } 3205 }
3206 3206
3207 3207
3208 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) { 3208 void LCodeGen::DoLoadKeyedGeneric(LLoadKeyedGeneric* instr) {
3209 ASSERT(ToRegister(instr->context()).is(esi)); 3209 ASSERT(ToRegister(instr->context()).is(esi));
3210 ASSERT(ToRegister(instr->object()).is(KeyedLoadIC::ReceiverRegister())); 3210 ASSERT(ToRegister(instr->object()).is(LoadIC::ReceiverRegister()));
3211 ASSERT(ToRegister(instr->key()).is(KeyedLoadIC::NameRegister())); 3211 ASSERT(ToRegister(instr->key()).is(LoadIC::NameRegister()));
3212 3212
3213 Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize(); 3213 Handle<Code> ic = isolate()->builtins()->KeyedLoadIC_Initialize();
3214 CallCode(ic, RelocInfo::CODE_TARGET, instr); 3214 CallCode(ic, RelocInfo::CODE_TARGET, instr);
3215 } 3215 }
3216 3216
3217 3217
3218 void LCodeGen::DoArgumentsElements(LArgumentsElements* instr) { 3218 void LCodeGen::DoArgumentsElements(LArgumentsElements* instr) {
3219 Register result = ToRegister(instr->result()); 3219 Register result = ToRegister(instr->result());
3220 3220
3221 if (instr->hydrogen()->from_inlined()) { 3221 if (instr->hydrogen()->from_inlined()) {
(...skipping 2440 matching lines...) Expand 10 before | Expand all | Expand 10 after
5662 CallRuntime(Runtime::kPushBlockContext, 2, instr); 5662 CallRuntime(Runtime::kPushBlockContext, 2, instr);
5663 RecordSafepoint(Safepoint::kNoLazyDeopt); 5663 RecordSafepoint(Safepoint::kNoLazyDeopt);
5664 } 5664 }
5665 5665
5666 5666
5667 #undef __ 5667 #undef __
5668 5668
5669 } } // namespace v8::internal 5669 } } // namespace v8::internal
5670 5670
5671 #endif // V8_TARGET_ARCH_IA32 5671 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698