tools/telemetry/telemetry/page/record_wpr.py - Issue 338883005: Add ForceGarbageCollection and PauseInteractive to ActionRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 338883005: Add ForceGarbageCollection and PauseInteractive to ActionRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/record_wpr.py

diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py

index d805a2ffa6e962763d32af816a883d44f05e7d51..988ed59a88f93afe068fe20a9e2a587c88ca99f0 100755

--- a/tools/telemetry/telemetry/page/record_wpr.py

+++ b/tools/telemetry/telemetry/page/record_wpr.py

@@ -19,7 +19,6 @@ from telemetry.page import page_test

from telemetry.page import profile_creator

from telemetry.page import test_expectations

from telemetry.page.actions import action_runner as action_runner_module

-from telemetry.page.actions import interact

from telemetry.results import page_measurement_results

@@ -70,7 +69,7 @@ class RecordPage(page_test.PageTest): # pylint: disable=W0223

self.RunNavigateSteps(page, tab)

action_runner = action_runner_module.ActionRunner(tab)

if interactive:

- action_runner.RunAction(interact.InteractAction())

+ action_runner.PauseInteractive()

else:

self._RunMethod(page, action_name, action_runner)

should_reload = True

« no previous file with comments | « tools/telemetry/telemetry/page/page_test.py ('k') | no next file » | no next file with comments »