tools/telemetry/telemetry/page/page_test.py - Issue 338883005: Add ForceGarbageCollection and PauseInteractive to ActionRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_test.py

Issue 338883005: Add ForceGarbageCollection and PauseInteractive to ActionRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_test.py

diff --git a/tools/telemetry/telemetry/page/page_test.py b/tools/telemetry/telemetry/page/page_test.py

index 6d858a8455596777fc5b12a7614d85e4f2bf15e1..60912a89172e180ed9c0c26b53b5361742fd9945 100644

--- a/tools/telemetry/telemetry/page/page_test.py

+++ b/tools/telemetry/telemetry/page/page_test.py

@@ -6,7 +6,6 @@ from telemetry.core import command_line

from telemetry.page import test_expectations

from telemetry.page.actions import action_runner as action_runner_module

-from telemetry.page.actions import interact

class Failure(Exception):

@@ -239,7 +238,7 @@ class PageTest(command_line.Command):

action_runner = action_runner_module.ActionRunner(tab)

self.WillRunActions(page, tab)

if interactive:

- action_runner.RunAction(interact.InteractAction())

+ action_runner.PauseInteractive()

else:

self._RunMethod(page, self._action_name_to_run, action_runner)

self.DidRunActions(page, tab)

« no previous file with comments | « tools/telemetry/telemetry/page/actions/js_collect_garbage.py ('k') | tools/telemetry/telemetry/page/record_wpr.py » ('j') | no next file with comments »