Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 338843005: IDL: For DOMString? attribute getters, use null string to represent null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/core/frame/NavigatorLanguage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index fddb3f1b8623bf5771ea0c2af88a9435dc10c942..2baf6d646b3635be31434abfc21a8d577df3351c 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -1520,9 +1520,8 @@ static void stringOrNullAttributeAttributeGetter(const v8::PropertyCallbackInfo<
{
v8::Handle<v8::Object> holder = info.Holder();
TestObject* impl = V8TestObject::toNative(holder);
- bool isNull = false;
- String cppValue(impl->stringOrNullAttribute(isNull));
- if (isNull) {
+ String cppValue(impl->stringOrNullAttribute());
Jens Widell 2014/06/30 10:43:41 For reference, this change is identical to the cha
+ if (!cppValue) {
v8SetReturnValueNull(info);
return;
}
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/core/frame/NavigatorLanguage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698