Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 338843005: IDL: For DOMString? attribute getters, use null string to represent null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/core/frame/NavigatorLanguage.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY!
6 6
7 #include "config.h" 7 #include "config.h"
8 #include "V8TestObject.h" 8 #include "V8TestObject.h"
9 9
10 #include "bindings/core/v8/V8HTMLCollection.h" 10 #include "bindings/core/v8/V8HTMLCollection.h"
(...skipping 1502 matching lines...) Expand 10 before | Expand all | Expand 10 after
1513 { 1513 {
1514 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter"); 1514 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");
1515 TestObjectV8Internal::floatArrayAttributeAttributeSetter(v8Value, info); 1515 TestObjectV8Internal::floatArrayAttributeAttributeSetter(v8Value, info);
1516 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution"); 1516 TRACE_EVENT_SET_SAMPLING_STATE("v8", "V8Execution");
1517 } 1517 }
1518 1518
1519 static void stringOrNullAttributeAttributeGetter(const v8::PropertyCallbackInfo< v8::Value>& info) 1519 static void stringOrNullAttributeAttributeGetter(const v8::PropertyCallbackInfo< v8::Value>& info)
1520 { 1520 {
1521 v8::Handle<v8::Object> holder = info.Holder(); 1521 v8::Handle<v8::Object> holder = info.Holder();
1522 TestObject* impl = V8TestObject::toNative(holder); 1522 TestObject* impl = V8TestObject::toNative(holder);
1523 bool isNull = false; 1523 String cppValue(impl->stringOrNullAttribute());
Jens Widell 2014/06/30 10:43:41 For reference, this change is identical to the cha
1524 String cppValue(impl->stringOrNullAttribute(isNull)); 1524 if (!cppValue) {
1525 if (isNull) {
1526 v8SetReturnValueNull(info); 1525 v8SetReturnValueNull(info);
1527 return; 1526 return;
1528 } 1527 }
1529 v8SetReturnValueString(info, cppValue, info.GetIsolate()); 1528 v8SetReturnValueString(info, cppValue, info.GetIsolate());
1530 } 1529 }
1531 1530
1532 static void stringOrNullAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info) 1531 static void stringOrNullAttributeAttributeGetterCallback(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)
1533 { 1532 {
1534 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter"); 1533 TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMGetter");
1535 TestObjectV8Internal::stringOrNullAttributeAttributeGetter(info); 1534 TestObjectV8Internal::stringOrNullAttributeAttributeGetter(info);
(...skipping 8658 matching lines...) Expand 10 before | Expand all | Expand 10 after
10194 fromInternalPointer(object)->deref(); 10193 fromInternalPointer(object)->deref();
10195 } 10194 }
10196 10195
10197 template<> 10196 template<>
10198 v8::Handle<v8::Value> toV8NoInline(TestObject* impl, v8::Handle<v8::Object> crea tionContext, v8::Isolate* isolate) 10197 v8::Handle<v8::Value> toV8NoInline(TestObject* impl, v8::Handle<v8::Object> crea tionContext, v8::Isolate* isolate)
10199 { 10198 {
10200 return toV8(impl, creationContext, isolate); 10199 return toV8(impl, creationContext, isolate);
10201 } 10200 }
10202 10201
10203 } // namespace WebCore 10202 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/core/frame/NavigatorLanguage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698