Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 338843005: IDL: For DOMString? attribute getters, use null string to represent null (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: For DOMString? attribute getters, use null string to represent null Same as we do for wrapper type attributes, where a null pointer is used to represent a null Javascript value, use a null string (one for which WTF::String::isNull() returns true) to represent a null Javascript value for nullable DOMString attributes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177221

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 2 chunks +6 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 chunk +2 lines, -3 lines 1 comment Download
M Source/core/frame/NavigatorLanguage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/NavigatorLanguage.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/canvas/MouseEventHitRegion.h View 1 chunk +8 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jens Widell
PTAL I intend to follow-up with a CL that drops the if-null-return-null code for nullable ...
6 years, 5 months ago (2014-06-30 10:43:41 UTC) #1
haraken
LGTM!
6 years, 5 months ago (2014-06-30 13:08:19 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-06-30 13:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/338843005/1
6 years, 5 months ago (2014-06-30 13:34:50 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 17:04:34 UTC) #5
Message was sent while issue was closed.
Change committed as 177221

Powered by Google App Engine
This is Rietveld 408576698