Issue 338833005: Fix incognito tab restore regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338833005: Fix incognito tab restore regression (Closed)

Created:
6 years, 6 months ago by acleung1

Modified:
6 years, 6 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix incognito tab restore regression It seems that the logic from the downstream file is different from the CL that upstreamed it. This CL restores the downstream logic. Consider this case: type == TabLaunchType.FROM_LONGPRESS_BACKGROUND: FALSE type == TabLaunchType.FROM_RESTORE: TRUE mTabModelSelector.isIncognitoSelected(): FALSE isNewTabIncognito: TRUE In the downstream version willOpenInForeground -> TRUE In the current version willOpenInForeground -> FALSE which incorrectlys restores the incognito tab even thought it isn't the current tab model. BUG=383470 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277851