chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java - Issue 338833005: Fix incognito tab restore regression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java

Issue 338833005: Fix incognito tab restore regression (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java

index d5ac68f725739164758d70992da39a45f12318f7..88176c8d91a380c9f3206bcdb211d5db77955427 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelOrderController.java

@@ -131,8 +131,8 @@ public class TabModelOrderController {

public boolean willOpenInForeground(TabLaunchType type, boolean isNewTabIncognito) {

// Restore is handling the active index by itself.

- return (type != TabLaunchType.FROM_LONGPRESS_BACKGROUND &&

- type != TabLaunchType.FROM_RESTORE)

+ if (type == TabLaunchType.FROM_RESTORE) return false;

+ return type != TabLaunchType.FROM_LONGPRESS_BACKGROUND

|| (!mTabModelSelector.isIncognitoSelected() && isNewTabIncognito);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »