Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 338653002: Revert of cc: Move tiling management out of draw properties calculation. (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 6 months ago
Reviewers:
danakj, sohanjg, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, reveman, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of cc: Move tiling management out of draw properties calculation. (https://codereview.chromium.org/271533011/) Reason for revert: BUG=384730 NOTREECHECKS=True TBR=enne@chromium.org,danakj@chromium.org Original issue's description: > cc: Move tiling management out of draw properties calculation. > > This is mainly plumbing code. > As part of the changes, we are moving ManageTiling as part of > UpdateTilePriorities. > We keep picturelayers content scale as 1,and maintain the remaining > required scales in draw properties. This scales we apply later, > to shared quad state and draw transform during AppendQuads. > > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277000

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+485 lines, -677 lines) Patch
M cc/layers/draw_properties.h View 2 chunks +1 line, -20 lines 0 comments Download
M cc/layers/picture_image_layer_impl.h View 2 chunks +8 lines, -2 lines 0 comments Download
M cc/layers/picture_image_layer_impl.cc View 2 chunks +22 lines, -7 lines 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 4 chunks +33 lines, -49 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 2 chunks +8 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 12 chunks +82 lines, -79 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 34 chunks +325 lines, -215 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/test/fake_picture_layer_impl.h View 2 chunks +0 lines, -13 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 3 chunks +1 line, -49 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +0 lines, -233 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tonyg
Created Revert of cc: Move tiling management out of draw properties calculation.
6 years, 6 months ago (2014-06-14 15:57:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/338653002/1
6 years, 6 months ago (2014-06-14 15:58:32 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 15:58:32 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-14 15:58:33 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-06-14 15:58:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/338653002/1
6 years, 6 months ago (2014-06-14 15:59:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 16:11:17 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 16:11:18 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698