Issue 338593003: Revert 274879 "Revert 274326 "Lobotomize the GPU memory manager""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 338593003: Revert 274879 "Revert 274326 "Lobotomize the GPU memory manager"" (Closed)

Created:
6 years, 6 months ago by ccameron

Modified:
6 years, 6 months ago

Reviewers:
ccameron

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 274879 "Revert 274326 "Lobotomize the GPU memory manager"" > Revert 274326 "Lobotomize the GPU memory manager" > BUG=380666 > > > Lobotomize the GPU memory manager > > > > On desktop, always set the memory limit to 256MB, and ask that the renderer > > only use that memory to draw content that is near the viewport. The effective > > limit prior to this patch was 384MB, but would quickly get cut down as multiple > > windows are opened, but would not fall too much lower than 256MB (e.g, 128 > > on Mac). > > > > On mobile, use all available memory for the current, only, renderer. > > > > Do not take into account unmanaged (e.g, WebGL) memory usage. > > > > BUG=377065 > > > > Review URL: https://codereview.chromium.org/308743005 > > TBR=ccameron@chromium.org > > Review URL: https://codereview.chromium.org/313163002 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277056

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -698 lines)			Patch
M	trunk/src/content/common/gpu/OWNERS	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/content/common/gpu/gpu_memory_manager.h	View	4 chunks	+5 lines, -79 lines	0 comments	Download
M	trunk/src/content/common/gpu/gpu_memory_manager.cc	View	10 chunks	+48 lines, -408 lines	0 comments	Download
M	trunk/src/content/common/gpu/gpu_memory_manager_client.h	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	trunk/src/content/common/gpu/gpu_memory_manager_client.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/src/content/common/gpu/gpu_memory_manager_unittest.cc	View	3 chunks	+2 lines, -182 lines	0 comments	Download
M	trunk/src/content/test/gpu/gpu_tests/memory.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r277056.

Expand Messages | Collapse Messages