Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 308743005: Lobotomize the GPU memory manager (Closed)

Created:
6 years, 6 months ago by ccameron
Modified:
6 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Lobotomize the GPU memory manager On desktop, always set the memory limit to 256MB, and ask that the renderer only use that memory to draw content that is near the viewport. The effective limit prior to this patch was 384MB, but would quickly get cut down as multiple windows are opened, but would not fall too much lower than 256MB (e.g, 128 on Mac). On mobile, use all available memory for the current, only, renderer. Do not take into account unmanaged (e.g, WebGL) memory usage. BUG=377065 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274326

Patch Set 1 #

Patch Set 2 : Fix Android build #

Patch Set 3 : Update OWNER #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -698 lines) Patch
M content/common/gpu/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.h View 4 chunks +5 lines, -79 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 11 chunks +48 lines, -408 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_client.h View 1 chunk +0 lines, -19 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_client.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 3 chunks +2 lines, -182 lines 0 comments Download
M content/test/gpu/gpu_tests/memory.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ccameron
This patch removes a lot of ineffective complexity from the memory manager. I think that ...
6 years, 6 months ago (2014-05-30 00:51:11 UTC) #1
Ken Russell (switch to Gerrit)
LGTM as far as I understand this code, which isn't well. Would you add yourself ...
6 years, 6 months ago (2014-05-31 01:31:15 UTC) #2
ccameron
On 2014/05/31 01:31:15, Ken Russell wrote: > LGTM as far as I understand this code, ...
6 years, 6 months ago (2014-06-02 17:48:14 UTC) #3
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 6 months ago (2014-06-02 18:18:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/308743005/40001
6 years, 6 months ago (2014-06-02 18:18:50 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 20:55:47 UTC) #6
Message was sent while issue was closed.
Change committed as 274326

Powered by Google App Engine
This is Rietveld 408576698