Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 338573002: Differentiate primary account compares on GAIA cookie presence. (Closed)

Created:
6 years, 6 months ago by Mike Lerman
Modified:
6 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Differentiate primary account compares on GAIA cookie presence. Added details to the UMA metrics for the account_reconcilor. BUG=357693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278475

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Patch Set 3 : Adjust unit tests for new UMA buckets. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -20 lines) Patch
M chrome/browser/signin/account_reconcilor_unittest.cc View 1 2 3 9 chunks +28 lines, -9 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M components/signin/core/browser/signin_metrics.h View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M components/signin/core/browser/signin_metrics.cc View 1 2 2 chunks +19 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mike Lerman
Cherished Reviewers, PTAL. Thanks!
6 years, 6 months ago (2014-06-13 15:57:40 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 6 months ago (2014-06-13 16:59:33 UTC) #2
Alexei Svitkine (slow)
sorry for the late review, lgtm % comments https://codereview.chromium.org/338573002/diff/1/components/signin/core/browser/signin_metrics.cc File components/signin/core/browser/signin_metrics.cc (right): https://codereview.chromium.org/338573002/diff/1/components/signin/core/browser/signin_metrics.cc#newcode28 components/signin/core/browser/signin_metrics.cc:28: int ...
6 years, 6 months ago (2014-06-17 19:43:04 UTC) #3
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 6 months ago (2014-06-19 15:45:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/338573002/60001
6 years, 6 months ago (2014-06-19 15:47:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 19:44:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85469)
6 years, 6 months ago (2014-06-19 19:44:35 UTC) #7
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 6 months ago (2014-06-19 20:05:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/338573002/60001
6 years, 6 months ago (2014-06-19 20:06:48 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 20:56:12 UTC) #10
Message was sent while issue was closed. 
Change committed as 278475

Powered by Google App Engine
This is Rietveld 408576698