Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: components/signin/core/browser/signin_metrics.h

Issue 338573002: Differentiate primary account compares on GAIA cookie presence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_ 5 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
6 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_ 6 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
7 7
8 namespace signin_metrics { 8 namespace signin_metrics {
9 9
10 // Enum for the ways in which primary account detection is done.
11 enum DifferentPrimaryAccounts {
12 // token and cookie had same primary accounts.
13 ACCOUNTS_SAME = 0,
14 // Deprecated. Indicates different primary accounts.
15 UNUSED_ACCOUNTS_DIFFERENT,
16 // No GAIA cookie present, so the primaries are considered different.
17 NO_COOKIE_PRESENT,
18 // There was at least one cookie and one token, and the primaries differed.
19 COOKIE_AND_TOKEN_PRIMARIES_DIFFERENT,
20 NUM_DIFFERENT_PRIMARY_ACCOUNT_METRICS,
21 };
22
10 // Log to UMA histograms and UserCounts stats about a single execution of the 23 // Log to UMA histograms and UserCounts stats about a single execution of the
11 // AccountReconciler. 24 // AccountReconciler.
12 // |total_number_accounts| - How many accounts are in the browser for this 25 // |total_number_accounts| - How many accounts are in the browser for this
13 // profile. 26 // profile.
14 // |count_added_to_cookie_jar| - How many accounts were in the browser but not 27 // |count_added_to_cookie_jar| - How many accounts were in the browser but not
15 // the cookie jar. 28 // the cookie jar.
16 // |count_added_to_token| - How may accounts were in the cookie jar but not in 29 // |count_added_to_token| - How may accounts were in the cookie jar but not in
17 // the browser. 30 // the browser.
18 // |primary_accounts_same| - False if the primary account for the cookie jar 31 // |primary_accounts_same| - False if the primary account for the cookie jar
19 // and the token service were different; else true. 32 // and the token service were different; else true.
20 // |is_first_reconcile| - True if these stats are from the first execution of 33 // |is_first_reconcile| - True if these stats are from the first execution of
21 // the AccountReconcilor. 34 // the AccountReconcilor.
35 // |pre_count_gaia_cookies| - How many GAIA cookies were present before
36 // the AccountReconcilor began modifying the state.
22 void LogSigninAccountReconciliation(int total_number_accounts, 37 void LogSigninAccountReconciliation(int total_number_accounts,
23 int count_added_to_cookie_jar, 38 int count_added_to_cookie_jar,
24 int count_added_to_token, 39 int count_added_to_token,
25 bool primary_accounts_same, 40 bool primary_accounts_same,
26 bool is_first_reconcile); 41 bool is_first_reconcile,
42 int pre_count_gaia_cookies);
27 43
28 // Track a successful signin. 44 // Track a successful signin.
29 void LogSigninAddAccount(); 45 void LogSigninAddAccount();
30 46
31 } // namespace signin_metrics 47 } // namespace signin_metrics
32 48
33 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_ 49 #endif // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_METRICS_H_
OLDNEW
« no previous file with comments | « components/signin/core/browser/account_reconcilor.cc ('k') | components/signin/core/browser/signin_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698