Issue 338493005: stop using SkBitmap::Config

Issue 338493005: stop using SkBitmap::Config (Closed)

Created:
6 years, 6 months ago by reed2

Modified:
6 years, 6 months ago

Reviewers:
scroggo

CC:
reviews_skia.org, reed1

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

stop using SkBitmap::Config TBR= Committed: https://skia.googlesource.com/skia/+/0689d7b12e7c427a077b003d3d8ae759d86f798f

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -89 lines)			Patch
M	src/gpu/SkGpuDevice.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGr.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/images/SkImageDecoder.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/images/SkImageDecoder_libgif.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/images/SkImageDecoder_libpng.cpp	View	1	15 chunks	+40 lines, -43 lines	0 comments	Download
M	src/images/SkImageDecoder_libwebp.cpp	View		7 chunks	+13 lines, -19 lines	2 comments	Download
M	src/images/SkImageEncoder_argb.cpp	View		2 chunks	+7 lines, -8 lines	0 comments	Download
M	src/images/SkScaledBitmapSampler.cpp	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/utils/SkTextureCompressor.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/KtxTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/picture_utils.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/skpdiff/SkCLImageDiffer.cpp	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/338493005/20001

6 years, 6 months ago (2014-06-14 11:53:57 UTC) #4

commit-bot: I haz the power

Change committed as 0689d7b12e7c427a077b003d3d8ae759d86f798f

6 years, 6 months ago (2014-06-14 12:30:24 UTC) #5

scroggo

6 years, 6 months ago (2014-06-16 14:50:32 UTC) #6

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/338493005/diff/20001/src/images/SkImageDecode...
File src/images/SkImageDecoder_libwebp.cpp (right):

https://codereview.chromium.org/338493005/diff/20001/src/images/SkImageDecode...
src/images/SkImageDecoder_libwebp.cpp:335: static bool
is_config_compatible(const SkBitmap& bitmap) {
is_colortype_compatible*

https://codereview.chromium.org/338493005/diff/20001/src/images/SkImageDecode...
src/images/SkImageDecoder_libwebp.cpp:557: static ScanlineImporter
ChooseImporter(SkColorType ct, bool  hasAlpha, int*  bpp) {
nit: double spaces between type and name are no longer needed.

Expand Messages | Collapse Messages