Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 338403002: Remove pnacl_profile_observer from pnacl's use of component updater. (Closed)

Created:
6 years, 6 months ago by jvoung (off chromium)
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove pnacl_profile_observer from pnacl's use of component updater. It was previously used for per-profile ChromeOS component installation, and then changed to do cleanup from that experiment. The files should be cleaned up by now, so remove that code. Stop registering PNaCl for component updates on ChromeOS also, since that was just for the cleanup. Eventually should move to using the default component installer w/ customization through traits, then we can get rid of the browser_process field. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -182 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.h View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 5 chunks +7 lines, -83 lines 0 comments Download
D chrome/browser/component_updater/pnacl/pnacl_profile_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/component_updater/pnacl/pnacl_profile_observer.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jvoung (off chromium)
6 years, 6 months ago (2014-06-17 18:43:57 UTC) #1
waffles
lgtm
6 years, 6 months ago (2014-06-17 19:47:18 UTC) #2
Sorin Jianu
lgtm Thank you!
6 years, 6 months ago (2014-06-17 20:26:46 UTC) #3
jvoung (off chromium)
Thanks! +jhawkins for chrome_browser_main.cc OWNERS
6 years, 6 months ago (2014-06-17 20:55:15 UTC) #4
James Hawkins
lgtm
6 years, 6 months ago (2014-06-17 20:57:12 UTC) #5
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 6 months ago (2014-06-17 22:13:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/338403002/1
6 years, 6 months ago (2014-06-17 22:16:10 UTC) #7
commit-bot: I haz the power
Change committed as 277898
6 years, 6 months ago (2014-06-17 23:24:16 UTC) #8
tommycli
6 years, 6 months ago (2014-06-17 23:44:24 UTC) #9
Message was sent while issue was closed.
On 2014/06/17 23:24:16, I haz the power (commit-bot) wrote:
> Change committed as 277898

jvoung: Thanks!!

Powered by Google App Engine
This is Rietveld 408576698