Remove pnacl_profile_observer from pnacl's use of component updater.

chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/pnacl/pnacl_component_installer.h"
 
 #include <string>
 #include <vector>
 
 #include "base/atomicops.h"
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "base/version.h"
 #include "base/win/windows_version.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/component_updater/component_updater_service.h"
 #include "chrome/browser/omaha_query_params/omaha_query_params.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/common/chrome_paths.h"
 #include "components/nacl/common/nacl_switches.h"
 #include "content/public/browser/browser_thread.h"
 
 using chrome::OmahaQueryParams;
 using content::BrowserThread;
 
 namespace component_updater {
 
 namespace {
@@ skipping 157 matching lines @@
     return false;
   }
 
   *version_out = version;
   return true;
 }
 
 }  // namespace
 
 PnaclComponentInstaller::PnaclComponentInstaller()
-    : per_user_(false), updates_disabled_(false), cus_(NULL) {
-#if defined(OS_CHROMEOS)
-  per_user_ = true;
-#endif
+    : updates_disabled_(false), cus_(NULL) {
 }
 
 PnaclComponentInstaller::~PnaclComponentInstaller() {
 }
 
 void PnaclComponentInstaller::OnUpdateError(int error) {
   NOTREACHED() << "Pnacl update error: " << error;
 }
 
 // Pnacl components have the version encoded in the path itself:
 // <profile>\AppData\Local\Google\Chrome\User Data\pnacl\0.1.2.3\.
 // and the base directory will be:
 // <profile>\AppData\Local\Google\Chrome\User Data\pnacl\.
 base::FilePath PnaclComponentInstaller::GetPnaclBaseDirectory() {
-  // For ChromeOS, temporarily make this user-dependent (for integrity) until
-  // we find a better solution.
-  // This is not ideal because of the following:
-  //   (a) We end up with per-user copies instead of a single copy
-  //   (b) The profile can change as users log in to different accounts
-  //   so we need to watch for user-login-events (see pnacl_profile_observer.h).
-  if (per_user_) {
-    DCHECK(!current_profile_path_.empty());
-    base::FilePath path =
-        current_profile_path_.Append(FILE_PATH_LITERAL("pnacl"));
-    return path;
-  } else {
-    base::FilePath result;
-    CHECK(PathService::Get(chrome::DIR_PNACL_BASE, &result));
-    return result;
-  }
-}
-
-void PnaclComponentInstaller::OnProfileChange() {
-  // On chromeos, we want to find the --login-profile=<foo> dir.
-  // Even though the path does vary between users, the content
-  // changes when logging out and logging in.
-  ProfileManager* pm = g_browser_process->profile_manager();
-  current_profile_path_ =
-      pm->user_data_dir().Append(pm->GetInitialProfileDir());
+  base::FilePath result;
+  CHECK(PathService::Get(chrome::DIR_PNACL_BASE, &result));
+  return result;
 }
 
 bool PnaclComponentInstaller::Install(const base::DictionaryValue& manifest,
                                       const base::FilePath& unpack_path) {
   scoped_ptr<base::DictionaryValue> pnacl_manifest(
       ReadPnaclManifest(unpack_path));
   if (pnacl_manifest == NULL) {
     LOG(WARNING) << "Failed to read pnacl manifest.";
     return false;
   }
@@ skipping 125 matching lines @@
                                      pci));
 
   // Remove older versions of PNaCl.
   for (std::vector<base::FilePath>::iterator iter = older_dirs.begin();
        iter != older_dirs.end();
        ++iter) {
     base::DeleteFile(*iter, true);
   }
 }
 
-// Remove old per-profile copies of PNaCl (was for ChromeOS).
-// TODO(jvoung): Delete this code once most ChromeOS users have reaped
-// their old per-profile copies of PNaCl.
-void ReapOldChromeOSPnaclFiles(PnaclComponentInstaller* pci) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
-  base::FilePath path = pci->GetPnaclBaseDirectory();
-  if (!base::PathExists(path))
-    return;
-
-  // Do a basic sanity check first.
-  if (pci->per_user() &&
-      path.BaseName().value().compare(FILE_PATH_LITERAL("pnacl")) == 0)
-    base::DeleteFile(path, true);
-}
-
-void GetProfileInformation(PnaclComponentInstaller* pci) {
-  // Bail if not logged in yet.
-  if (!g_browser_process->profile_manager()->IsLoggedIn()) {
-    return;
-  }
-
-  pci->OnProfileChange();
-
-  // Do not actually register PNaCl for component updates, for CHROMEOS.
-  // Just get the profile information and delete the per-profile files
-  // if they exist.
-  BrowserThread::PostTask(BrowserThread::FILE,
-                          FROM_HERE,
-                          base::Bind(&ReapOldChromeOSPnaclFiles, pci));
-}
-
 }  // namespace
 
 void PnaclComponentInstaller::RegisterPnaclComponent(
     ComponentUpdateService* cus,
     const CommandLine& command_line) {
   // Register PNaCl by default (can be disabled).
   updates_disabled_ = command_line.HasSwitch(switches::kDisablePnaclInstall);
   cus_ = cus;
-  // If per_user, create a profile observer to watch for logins.
-  // Only do so after cus_ is set to something non-null.
-  if (per_user_ && !profile_observer_) {
-    profile_observer_.reset(new PnaclProfileObserver(this));
-  }
-  if (per_user_) {
-    // Figure out profile information, before proceeding to look for files.
-    BrowserThread::PostTask(
-        BrowserThread::UI, FROM_HERE, base::Bind(&GetProfileInformation, this));
-  } else {
-    BrowserThread::PostTask(BrowserThread::FILE,
-                            FROM_HERE,
-                            base::Bind(&StartPnaclUpdateRegistration, this));
-  }
-}
-
-void PnaclComponentInstaller::ReRegisterPnacl() {
-  DCHECK(per_user_);
-  // Figure out profile information, before proceeding to look for files.
-  BrowserThread::PostTask(
-      BrowserThread::UI, FROM_HERE, base::Bind(&GetProfileInformation, this));
+  BrowserThread::PostTask(BrowserThread::FILE,
+                          FROM_HERE,
+                          base::Bind(&StartPnaclUpdateRegistration, this));
 }
 
 }  // namespace component_updater
 
 namespace pnacl {
 
 bool NeedsOnDemandUpdate() {
   return base::subtle::NoBarrier_Load(
              &component_updater::needs_on_demand_update) != 0;
 }
 
 }  // namespace pnacl