Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: components/gcm_driver/gcm_driver.cc

Issue 338363003: Push API: register PushMessagingServiceImpl as GCMAppHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add as AppHandler before calling Register. Other review issues. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver.cc
diff --git a/components/gcm_driver/gcm_driver.cc b/components/gcm_driver/gcm_driver.cc
index 345fa97dce156622f51083e91f9a98277c68cf9d..ef90b93e8553f2bf0abf05aded11ef90d25b9903 100644
--- a/components/gcm_driver/gcm_driver.cc
+++ b/components/gcm_driver/gcm_driver.cc
@@ -148,7 +148,7 @@ void GCMDriver::AddAppHandler(const std::string& app_id,
GCMAppHandler* handler) {
DCHECK(!app_id.empty());
DCHECK(handler);
- DCHECK(app_handlers_.find(app_id) == app_handlers_.end());
+ DCHECK(app_handlers_.count(app_id) == 0);
jochen (gone - plz use gerrit) 2014/06/18 03:58:40 DCHECK_EQ
Michael van Ouwerkerk 2014/06/18 11:17:51 Done.
app_handlers_[app_id] = handler;
}
@@ -158,8 +158,18 @@ void GCMDriver::RemoveAppHandler(const std::string& app_id) {
}
GCMAppHandler* GCMDriver::GetAppHandler(const std::string& app_id) {
+ // Look for exact match.
GCMAppHandlerMap::const_iterator iter = app_handlers_.find(app_id);
- return iter == app_handlers_.end() ? &default_app_handler_ : iter->second;
+ if (iter != app_handlers_.end())
+ return iter->second;
+
+ // Ask the handlers whether they know how to handle it.
+ for (iter = app_handlers_.begin(); iter != app_handlers_.end(); ++iter) {
+ if (iter->second->CanHandle(app_id))
+ return iter->second;
+ }
+
+ return &default_app_handler_;
}
bool GCMDriver::HasRegisterCallback(const std::string& app_id) {

Powered by Google App Engine
This is Rietveld 408576698