Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: components/gcm_driver/gcm_driver.h

Issue 338363003: Push API: register PushMessagingServiceImpl as GCMAppHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add as AppHandler before calling Register. Other review issues. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver.h
diff --git a/components/gcm_driver/gcm_driver.h b/components/gcm_driver/gcm_driver.h
index a215abddf6ce6f67e87379baa191c95d9c84931e..46f2c7d087e1581d3275628a20ed47c70c284534 100644
--- a/components/gcm_driver/gcm_driver.h
+++ b/components/gcm_driver/gcm_driver.h
@@ -73,6 +73,9 @@ class GCMDriver {
// Remove the handler for a given app.
virtual void RemoveAppHandler(const std::string& app_id);
+ // Returns the handler for the given app.
+ GCMAppHandler* GetAppHandler(const std::string& app_id);
+
// Enables/disables GCM service.
virtual void Enable() = 0;
virtual void Disable() = 0;
@@ -136,9 +139,6 @@ class GCMDriver {
void ClearCallbacks();
- // Returns the handler for the given app.
- GCMAppHandler* GetAppHandler(const std::string& app_id);
-
private:
// Should be called when an app with |app_id| is trying to un/register.
// Checks whether another un/registration is in progress.

Powered by Google App Engine
This is Rietveld 408576698