Source/core/css/MediaQueryMatcher.cpp - Issue 337883003: Call media query change listeners asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryMatcher.cpp

Issue 337883003: Call media query change listeners asynchronously. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: fix typo Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryMatcher.cpp

diff --git a/Source/core/css/MediaQueryMatcher.cpp b/Source/core/css/MediaQueryMatcher.cpp

index c9e748ea306699aa06658f8c756d77aa2e86f90d..d50048fd76a55264e382cf5285fe83dc7df53903 100644

--- a/Source/core/css/MediaQueryMatcher.cpp

+++ b/Source/core/css/MediaQueryMatcher.cpp

@@ -109,9 +109,7 @@ void MediaQueryMatcher::mediaFeaturesChanged()

for (MediaQueryListSet::iterator it = m_mediaLists.begin(); it != m_mediaLists.end(); ++it)

(*it)->mediaFeaturesChanged(&listenersToNotify);

- // FIXME: This should be async! We're running script inside ::layout() or ::updateRenderTree().

- for (size_t i = 0; i < listenersToNotify.size(); ++i)

- listenersToNotify[i]->call();

+ m_document->enqueueMediaQueryChangeListeners(listenersToNotify);

}

void MediaQueryMatcher::trace(Visitor* visitor)