Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: Source/core/css/MediaQueryMatcher.cpp

Issue 337883003: Call media query change listeners asynchronously. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix typo Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 102
103 void MediaQueryMatcher::mediaFeaturesChanged() 103 void MediaQueryMatcher::mediaFeaturesChanged()
104 { 104 {
105 if (!m_document) 105 if (!m_document)
106 return; 106 return;
107 107
108 WillBeHeapVector<RefPtrWillBeMember<MediaQueryListListener> > listenersToNot ify; 108 WillBeHeapVector<RefPtrWillBeMember<MediaQueryListListener> > listenersToNot ify;
109 for (MediaQueryListSet::iterator it = m_mediaLists.begin(); it != m_mediaLis ts.end(); ++it) 109 for (MediaQueryListSet::iterator it = m_mediaLists.begin(); it != m_mediaLis ts.end(); ++it)
110 (*it)->mediaFeaturesChanged(&listenersToNotify); 110 (*it)->mediaFeaturesChanged(&listenersToNotify);
111 111
112 // FIXME: This should be async! We're running script inside ::layout() or :: updateRenderTree(). 112 m_document->enqueueMediaQueryChangeListeners(listenersToNotify);
113 for (size_t i = 0; i < listenersToNotify.size(); ++i)
114 listenersToNotify[i]->call();
115 } 113 }
116 114
117 void MediaQueryMatcher::trace(Visitor* visitor) 115 void MediaQueryMatcher::trace(Visitor* visitor)
118 { 116 {
119 visitor->trace(m_document); 117 visitor->trace(m_document);
120 visitor->trace(m_mediaLists); 118 visitor->trace(m_mediaLists);
121 } 119 }
122 120
123 } 121 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698