Add trace links to chrome://inspect (if chrome://inspect?tracing is used)

Add trace links to chrome://inspect (if chrome://inspect?tracing is used)

This patch adds trace links to chrome://inspect if you add the
"tracing" parameter to chrome://inspect. Clicking on the trace link
opens up chrome://tracing.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277781

[pdr., 2014-06-13 21:20:36]

@pfeldman, on a scale of 9 to 10, WDYT?

[pfeldman, 2014-06-16 17:11:16]

https://codereview.chromium.org/337803003/diff/1/chrome/browser/resources/ins...
File chrome/browser/resources/inspect/inspect.js (right):

https://codereview.chromium.org/337803003/diff/1/chrome/browser/resources/ins...
chrome/browser/resources/inspect/inspect.js:332: 
Is there a reason to not do something like below (and not touch the backend
part?)

var browserInspector;
var browserInspectorTitle;

if ('trace' in queryParamsObject || 'tracing' in queryParamsObject) {
  browserInspector = 'chrome://tracing';
  browserInspectorTitle = 'trace';
else {
  browserInspector = queryParamsObject['browser-inspector'];
  browserInspectorTitle = 'trace';
}

if (browserInspector) {
  ...

[pdr., 2014-06-16 22:57:38]

On 2014/06/16 17:11:16, pfeldman wrote:
>
https://codereview.chromium.org/337803003/diff/1/chrome/browser/resources/ins...
> File chrome/browser/resources/inspect/inspect.js (right):
> 
>
https://codereview.chromium.org/337803003/diff/1/chrome/browser/resources/ins...
> chrome/browser/resources/inspect/inspect.js:332: 
> Is there a reason to not do something like below (and not touch the backend
> part?)
> 
> var browserInspector;
> var browserInspectorTitle;
> 
> if ('trace' in queryParamsObject || 'tracing' in queryParamsObject) {
>   browserInspector = 'chrome://tracing';
>   browserInspectorTitle = 'trace';
> else {
>   browserInspector = queryParamsObject['browser-inspector'];
>   browserInspectorTitle = 'trace';
> }
> 
> if (browserInspector) {
>   ...

This is a great point. I thought we were going to need more chrome-side
infrastructure but it looks like you've handled all the hard lifting already :)

PTAL, updated with the simpler approach you suggested.

[pfeldman, 2014-06-17 10:29:27]

lgtm

[pdr., 2014-06-17 13:37:15]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-06-17 13:37:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/337803003/20001

[commit-bot: I haz the power, 2014-06-17 16:46:47]

Change committed as 277781