Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/resources/inspect/inspect.js

Issue 337803003: Add trace links to chrome://inspect (if chrome://inspect?tracing is used) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update per reviewer comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/inspect/inspect.js
diff --git a/chrome/browser/resources/inspect/inspect.js b/chrome/browser/resources/inspect/inspect.js
index e18a8814760405172de360ee529d74c87717d730..df572218b8bc98f1f81c92712439fc547c46b801 100644
--- a/chrome/browser/resources/inspect/inspect.js
+++ b/chrome/browser/resources/inspect/inspect.js
@@ -330,16 +330,25 @@ function populateRemoteTargets(devices) {
browserHeader.appendChild(newPage);
}
- if (queryParamsObject['browser-inspector']) {
+ var browserInspector;
+ var browserInspectorTitle;
+ if ('trace' in queryParamsObject || 'tracing' in queryParamsObject) {
+ browserInspector = 'chrome://tracing';
+ browserInspectorTitle = 'trace';
+ } else {
+ browserInspector = queryParamsObject['browser-inspector'];
+ browserInspectorTitle = 'inspect';
+ }
+ if (browserInspector) {
var link = document.createElement('span');
link.classList.add('action');
link.setAttribute('tabindex', 1);
- link.textContent = 'inspect';
+ link.textContent = browserInspectorTitle;
browserHeader.appendChild(link);
link.addEventListener(
'click',
sendCommand.bind(null, 'inspect-browser', browser.source,
- browser.id, queryParamsObject['browser-inspector']), false);
+ browser.id, browserInspector), false);
}
pageList = document.createElement('div');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698