Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: content/browser/gpu/compositor_util.cc

Issue 337783002: Remove EnableThreadedCompositing from the browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: thread: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/compositor_util.h ('k') | content/browser/gpu/compositor_util_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/compositor_util.cc
diff --git a/content/browser/gpu/compositor_util.cc b/content/browser/gpu/compositor_util.cc
index bcc6a9e772177907e6c7e19559dd936eca005674..844f63deb97763dffa2dbd229ceeed84df96a9a3 100644
--- a/content/browser/gpu/compositor_util.cc
+++ b/content/browser/gpu/compositor_util.cc
@@ -178,24 +178,6 @@ bool IsPinchVirtualViewportEnabled() {
#endif
}
-bool IsThreadedCompositingEnabled() {
- const CommandLine& command_line = *CommandLine::ForCurrentProcess();
-
- // Command line switches take precedence over blacklist.
- if (command_line.HasSwitch(switches::kDisableThreadedCompositing))
- return false;
- if (command_line.HasSwitch(switches::kEnableThreadedCompositing))
- return true;
-
-#if defined(USE_AURA) || defined(OS_MACOSX)
- // We always want threaded compositing on Aura and Mac (the fallback is a
- // threaded software compositor).
- return true;
-#else
- return false;
-#endif
-}
-
bool IsDelegatedRendererEnabled() {
const CommandLine& command_line = *CommandLine::ForCurrentProcess();
bool enabled = false;
@@ -208,14 +190,6 @@ bool IsDelegatedRendererEnabled() {
// Flags override.
enabled |= command_line.HasSwitch(switches::kEnableDelegatedRenderer);
enabled &= !command_line.HasSwitch(switches::kDisableDelegatedRenderer);
-
- // Needs compositing, and thread.
- if (enabled && !IsThreadedCompositingEnabled()) {
- enabled = false;
- LOG(ERROR) << "Disabling delegated-rendering because it needs "
- << "threaded-compositing.";
- }
-
return enabled;
}
@@ -233,7 +207,7 @@ bool IsImplSidePaintingEnabled() {
#if defined(OS_MACOSX) || defined(OS_WIN)
return false;
#else
- return IsThreadedCompositingEnabled();
+ return true;
#endif
}
@@ -303,10 +277,6 @@ base::Value* GetFeatureStatus() {
if (gpu_feature_info.name == kThreadedRasterizationFeatureName)
status += "_on";
}
- if (gpu_feature_info.name == kGpuCompositingFeatureName) {
- if (IsThreadedCompositingEnabled())
- status += "_threaded";
- }
if (gpu_feature_info.name == kWebGLFeatureName &&
(gpu_feature_info.blocked || gpu_access_blocked) &&
manager->ShouldUseSwiftShader()) {
« no previous file with comments | « content/browser/gpu/compositor_util.h ('k') | content/browser/gpu/compositor_util_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698