Make iterator for Element's attributes more lightweight

Make iterator for Element's attributes more lightweight

Make iterator for Element's attributes more lightweight. Kill the
AttributeConstIterator class and make the iterator a simple pointer instead
(similarly to the Vector iterator). Also rename the AttributeIteratorAccessor
class to AttributeCollection as I think it looks better. This CL adds a typedef
so that the iterator is now used as AttributeCollection::const_iterator.

Also rename the attributesIterator() method to attributes() for simplicity.

R=esprehn@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176430

[esprehn, 2014-06-18 06:08:39]

lgtm

[commit-bot: I haz the power, 2014-06-18 06:09:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/337753005/1

[commit-bot: I haz the power, 2014-06-18 06:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 06:10:03]

Failed to apply patch for Source/core/dom/Element.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Element.cpp
  Hunk #1 succeeded at 317 (offset -35 lines).
  Hunk #2 succeeded at 1211 (offset -30 lines).
  Hunk #3 FAILED at 3024.
  Hunk #4 succeeded at 3075 (offset -17 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
Source/core/dom/Element.cpp.rej

Patch:       Source/core/dom/Element.cpp
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index
74d3965142bd8e6dea27cf522c36500443f7d29d..ed35d7f38d15ff75f4423d9c605f366d6e7b1491
100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -352,7 +352,7 @@ void Element::setBooleanAttribute(const QualifiedName& name,
bool value)
         removeAttribute(name);
 }
 
-NamedNodeMap* Element::attributes() const
+NamedNodeMap* Element::attributesForBindings() const
 {
     ElementRareData& rareData =
const_cast<Element*>(this)->ensureElementRareData();
     if (NamedNodeMap* attributeMap = rareData.attributeMap())
@@ -1241,9 +1241,9 @@ const AtomicString& Element::locateNamespacePrefix(const
AtomicString& namespace
         return prefix();
 
     if (hasAttributes()) {
-        AttributeIteratorAccessor attributes = attributesIterator();
-        AttributeConstIterator end = attributes.end();
-        for (AttributeConstIterator it = attributes.begin(); it != end; ++it) {
+        AttributeCollection attributes = this->attributes();
+        AttributeCollection::const_iterator end = attributes.end();
+        for (AttributeCollection::const_iterator it = attributes.begin(); it !=
end; ++it) {
             if (it->prefix() == xmlnsAtom && it->value() == namespaceToLocate)
                 return it->localName();
         }
@@ -3024,9 +3024,9 @@ void Element::detachAllAttrNodesFromElement()
     AttrNodeList* attrNodeList = attrNodeListForElement(this);
     ASSERT(attrNodeList);
 
-    AttributeIteratorAccessor attributes = attributesIterator();
-    AttributeConstIterator end = attributes.end();
-    for (AttributeConstIterator it = attributes.begin(); it != end; ++it) {
+    AttributeCollection attributes = this->attributes();
+    AttributeCollection::const_iterator end = attributes.end();
+    for (AttributeCollection::const_iterator it = attributes.begin(); it !=
end; ++it) {
         if (RefPtrWillBeRawPtr<Attr> attrNode =
findAttrNodeInList(*attrNodeList, it->name()))
             attrNode->detachFromElementWithValue(it->value());
     }
@@ -3092,9 +3092,9 @@ void Element::cloneAttributesFromElement(const Element&
other)
     else
         m_elementData = other.m_elementData->makeUniqueCopy();
 
-    AttributeIteratorAccessor attributes = m_elementData->attributesIterator();
-    AttributeConstIterator end = attributes.end();
-    for (AttributeConstIterator it = attributes.begin(); it != end; ++it)
+    AttributeCollection attributes = m_elementData->attributes();
+    AttributeCollection::const_iterator end = attributes.end();
+    for (AttributeCollection::const_iterator it = attributes.begin(); it !=
end; ++it)
         attributeChangedFromParserOrByCloning(it->name(), it->value(),
ModifiedByCloning);
 }

[Inactive, 2014-06-18 12:19:33]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-18 12:20:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/337753005/20001

[Inactive, 2014-06-18 12:30:12]

The CQ bit was unchecked by ch.dumez@samsung.com

[Inactive, 2014-06-18 12:32:26]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-18 12:32:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/337753005/40001

[commit-bot: I haz the power, 2014-06-18 14:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 14:19:12]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11864)

[Inactive, 2014-06-18 14:21:48]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-18 14:22:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/337753005/40001

[commit-bot: I haz the power, 2014-06-18 16:20:27]

Change committed as 176430