Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: Source/core/css/SelectorChecker.cpp

Issue 337753005: Make iterator for Element's attributes more lightweight (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Proper rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/SelectorChecker.h ('k') | Source/core/dom/DatasetDOMStringMap.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 492
493 // Synchronize the attribute in case it is lazy-computed. 493 // Synchronize the attribute in case it is lazy-computed.
494 // Currently all lazy properties have a null namespace, so only pass localNa me(). 494 // Currently all lazy properties have a null namespace, so only pass localNa me().
495 element.synchronizeAttribute(selectorAttr.localName()); 495 element.synchronizeAttribute(selectorAttr.localName());
496 496
497 if (!element.hasAttributesWithoutUpdate()) 497 if (!element.hasAttributesWithoutUpdate())
498 return false; 498 return false;
499 499
500 const AtomicString& selectorValue = selector.value(); 500 const AtomicString& selectorValue = selector.value();
501 501
502 AttributeIteratorAccessor attributes = element.attributesIterator(); 502 AttributeCollection attributes = element.attributes();
503 AttributeConstIterator end = attributes.end(); 503 AttributeCollection::const_iterator end = attributes.end();
504 for (AttributeConstIterator it = attributes.begin(); it != end; ++it) { 504 for (AttributeCollection::const_iterator it = attributes.begin(); it != end; ++it) {
505 const Attribute& attributeItem = **it; 505 const Attribute& attributeItem = *it;
506 506
507 if (!attributeItem.matches(selectorAttr)) 507 if (!attributeItem.matches(selectorAttr))
508 continue; 508 continue;
509 509
510 if (attributeValueMatches(attributeItem, match, selectorValue, true)) 510 if (attributeValueMatches(attributeItem, match, selectorValue, true))
511 return true; 511 return true;
512 512
513 // Case sensitivity for attribute matching is looser than hasAttribute o r 513 // Case sensitivity for attribute matching is looser than hasAttribute o r
514 // Element::shouldIgnoreAttributeCase() for now. Unclear if that's corre ct. 514 // Element::shouldIgnoreAttributeCase() for now. Unclear if that's corre ct.
515 bool caseSensitive = !element.document().isHTMLDocument() || HTMLDocumen t::isCaseSensitiveAttribute(selectorAttr); 515 bool caseSensitive = !element.document().isHTMLDocument() || HTMLDocumen t::isCaseSensitiveAttribute(selectorAttr);
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
1149 return element.focused() && isFrameFocused(element); 1149 return element.focused() && isFrameFocused(element);
1150 } 1150 }
1151 1151
1152 template 1152 template
1153 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const; 1153 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const;
1154 1154
1155 template 1155 template
1156 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const; 1156 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const;
1157 1157
1158 } 1158 }
OLDNEW
« no previous file with comments | « Source/core/css/SelectorChecker.h ('k') | Source/core/dom/DatasetDOMStringMap.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698