Issue 337723004: [Safe browsing] Clean up code to scan hash results for threats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337723004: [Safe browsing] Clean up code to scan hash results for threats. (Closed)

Created:
6 years, 6 months ago by Scott Hess - ex-Googler

Modified:
6 years, 6 months ago

Reviewers:
mattm

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Safe browsing] Clean up code to scan hash results for threats. Rewrite safe_browsing_util::GetHashIndex() and GetUrlHashIndex() to use sensible return types rather than transitioning to/from int. Pull them into database_manager.cc, which was the only place they were used. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277997

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -74 lines)			Patch
M	chrome/browser/safe_browsing/database_manager.h	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/database_manager.cc	View	3 chunks	+68 lines, -26 lines	0 comments	Download
M	chrome/browser/safe_browsing/database_manager_unittest.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_util_unittest.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

The CQ bit was checked by shess@chromium.org

6 years, 6 months ago (2014-06-17 20:36:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/337723004/1

6 years, 6 months ago (2014-06-17 20:40:41 UTC) #4

Message was sent while issue was closed.

Change committed as 277997

Expand Messages | Collapse Messages