Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: chrome/browser/safe_browsing/database_manager_unittest.cc

Issue 337723004: [Safe browsing] Clean up code to scan hash results for threats. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/database_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/database_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/database_manager_unittest.cc b/chrome/browser/safe_browsing/database_manager_unittest.cc
index af7fda4740e97d72492e285eba10608e696fa23a..5639046de527bcd8892cac6d2d0dd3fa77d59f16 100644
--- a/chrome/browser/safe_browsing/database_manager_unittest.cc
+++ b/chrome/browser/safe_browsing/database_manager_unittest.cc
@@ -78,3 +78,53 @@ TEST_F(SafeBrowsingDatabaseManagerTest, CheckCorrespondsListType) {
multiple_threats,
safe_browsing_util::kMalwareList));
}
+
+TEST_F(SafeBrowsingDatabaseManagerTest, GetUrlThreatType) {
+ std::vector<SBFullHashResult> full_hashes;
+
+ const GURL kMalwareUrl("http://www.malware.com/page.html");
+ const GURL kPhishingUrl("http://www.phishing.com/page.html");
+ const GURL kSafeUrl("http://www.safe.com/page.html");
+
+ const SBFullHash kMalwareHostHash = SBFullHashForString("malware.com/");
+ const SBFullHash kPhishingHostHash = SBFullHashForString("phishing.com/");
+ const SBFullHash kSafeHostHash = SBFullHashForString("www.safe.com/");
+
+ {
+ SBFullHashResult full_hash;
+ full_hash.hash = kMalwareHostHash;
+ full_hash.list_id = static_cast<int>(safe_browsing_util::MALWARE);
+ full_hashes.push_back(full_hash);
+ }
+
+ {
+ SBFullHashResult full_hash;
+ full_hash.hash = kPhishingHostHash;
+ full_hash.list_id = static_cast<int>(safe_browsing_util::PHISH);
+ full_hashes.push_back(full_hash);
+ }
+
+ EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
+ SafeBrowsingDatabaseManager::GetHashThreatType(
+ kMalwareHostHash, full_hashes));
+
+ EXPECT_EQ(SB_THREAT_TYPE_URL_PHISHING,
+ SafeBrowsingDatabaseManager::GetHashThreatType(
+ kPhishingHostHash, full_hashes));
+
+ EXPECT_EQ(SB_THREAT_TYPE_SAFE,
+ SafeBrowsingDatabaseManager::GetHashThreatType(
+ kSafeHostHash, full_hashes));
+
+ EXPECT_EQ(SB_THREAT_TYPE_URL_MALWARE,
+ SafeBrowsingDatabaseManager::GetUrlThreatType(
+ kMalwareUrl, full_hashes));
+
+ EXPECT_EQ(SB_THREAT_TYPE_URL_PHISHING,
+ SafeBrowsingDatabaseManager::GetUrlThreatType(
+ kPhishingUrl, full_hashes));
+
+ EXPECT_EQ(SB_THREAT_TYPE_SAFE,
+ SafeBrowsingDatabaseManager::GetUrlThreatType(
+ kSafeUrl, full_hashes));
+}
« no previous file with comments | « chrome/browser/safe_browsing/database_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698