Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 337683002: Revert of Implement software fallback for PPB_VideoDecoder. (Closed)

Created:
6 years, 6 months ago by Stephen Chennney
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Revert of Implement software fallback for PPB_VideoDecoder. (https://codereview.chromium.org/311853005/) Reason for revert: Broke blink Linux tests compile.http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/37259 Original issue's description: > Implement software fallback for PPB_VideoDecoder. > This modifies the proxy to implement software fallback mode. > The main change is to the host, which now can work with > media::VideoDecoders. > > media::VideoDecoder works differently from media::VideoDecodeAccelerator > so an adapter object, content::VideoDecoderShim is defined. It lives on the main thread and drives the actual decoder on the media thread via a child DecoderImpl class, which sends back frames of video. VideoDecoderShim receives those and converts frames to GL textures. > > gpu::Mailboxes are used so the host can create textures that are aliased > to the plugin's textures. > > The test plugin has been changed to include bitstream data for VP8 in order to > test the software decoder. The data is in ppapi/examples/video_decode/testdata.h > alongside the H264 data. The file diff is too large for this site but is structured > something like this: > > const unsigned char kData[] = { > #if defined USE_VP8_TESTDATA_INSTEAD_OF_H264 > ... lots of VP8 data > > #else // !USE_VP8_TESTDATA_INSTEAD_OF_H264 > ... lots of H264 data > > #endif // USE_VP8_TESTDATA_INSTEAD_OF_H264 > }; > > > There is a TODO to convert the example to load a file. I'm not sure how to go > about that but am willing to do the work if someone can point the way. > > BUG=281689 > R=dmichael@chromium.org, fischman@chromium.org, sievers@chromium.org, tsepez@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277012 TBR=dmichael@chromium.org,fischman@chromium.org,igorc@chromium.org,piman@chromium.org,sievers@chromium.org,tsepez@chromium.org,bbudge@chromium.org NOTREECHECKS=true NOTRY=true BUG=281689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1024 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 3 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.h View 6 chunks +5 lines, -16 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 9 chunks +50 lines, -76 lines 0 comments Download
D content/renderer/pepper/video_decoder_shim.h View 1 chunk +0 lines, -129 lines 0 comments Download
D content/renderer/pepper/video_decoder_shim.cc View 1 chunk +0 lines, -576 lines 0 comments Download
M content/test/ppapi/ppapi_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/cmd_buffer_common.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/gpu.gyp View 2 chunks +3 lines, -26 lines 0 comments Download
M ppapi/examples/video_decode/video_decode.cc View 11 chunks +23 lines, -68 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ppapi/proxy/video_decoder_resource.h View 2 chunks +1 line, -3 lines 0 comments Download
M ppapi/proxy/video_decoder_resource.cc View 4 chunks +2 lines, -9 lines 0 comments Download
M ppapi/proxy/video_decoder_resource_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
D ppapi/tests/test_video_decoder.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ppapi/tests/test_video_decoder.cc View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen Chennney
Created Revert of Implement software fallback for PPB_VideoDecoder.
6 years, 6 months ago (2014-06-13 14:33:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/schenney@chromium.org/337683002/1
6 years, 6 months ago (2014-06-13 14:34:18 UTC) #2
bbudge-google
The CQ bit was unchecked by bbudge@google.com
6 years, 6 months ago (2014-06-13 14:34:50 UTC) #3
commit-bot: I haz the power
Change committed as 277015
6 years, 6 months ago (2014-06-13 14:35:24 UTC) #4
bbudge-google
On 2014/06/13 14:34:18, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-13 14:35:51 UTC) #5
Stephen Chennney
6 years, 6 months ago (2014-06-13 14:57:37 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/333903002/ by schenney@chromium.org.

The reason for reverting is: Revert of revert, which apparently wasn't a full
revert..

Powered by Google App Engine
This is Rietveld 408576698