Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
337353002:
Object properties with values of Symbol type should not be expandable. (Closed)
|
Created:
6 years, 6 months ago by Alexandra Mikhaylova Modified:
6 years, 6 months ago Reviewers:
aandrey CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Project:
blink Visibility:
Public. |
DescriptionObject properties with values of Symbol type should not be expandable.
BUG=376194
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176326
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address comments #
Total comments: 2
Patch Set 3 : Address comments #Messages
Total messages: 14 (0 generated)
https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/co... File Source/devtools/front_end/components/ObjectPropertiesSection.js (right): https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/co... Source/devtools/front_end/components/ObjectPropertiesSection.js:246: this.hasChildren = this.property.value.hasChildren && !this.property.wasThrown && !(this.property.value.type === "symbol"); this.property.value.hasChildren should be false for symbols
On 2014/06/17 10:36:34, aandrey wrote: > https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/co... > File Source/devtools/front_end/components/ObjectPropertiesSection.js (right): > > https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/co... > Source/devtools/front_end/components/ObjectPropertiesSection.js:246: > this.hasChildren = this.property.value.hasChildren && !this.property.wasThrown > && !(this.property.value.type === "symbol"); > this.property.value.hasChildren should be false for symbols so should we check the type and set hasChildren accordingly right in the tree element constructor instead?
On 2014/06/17 10:57:54, Alexandra Mikhaylova wrote: > On 2014/06/17 10:36:34, aandrey wrote: > > > https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/co... > > File Source/devtools/front_end/components/ObjectPropertiesSection.js (right): > > > > > https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/co... > > Source/devtools/front_end/components/ObjectPropertiesSection.js:246: > > this.hasChildren = this.property.value.hasChildren && !this.property.wasThrown > > && !(this.property.value.type === "symbol"); > > this.property.value.hasChildren should be false for symbols > > so should we check the type and set hasChildren accordingly right in the tree > element constructor instead? RemoteObject for symbol should return false for hasChildren
thanks, fixed this
lgtm https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_en... File Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_en... Source/devtools/front_end/sdk/RemoteObject.js:225: this._hasChildren = this._type === "symbol" ? false : true; this._hasChildren = (type !== "symbol");
https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_en... File Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_en... Source/devtools/front_end/sdk/RemoteObject.js:225: this._hasChildren = this._type === "symbol" ? false : true; On 2014/06/17 12:29:37, aandrey wrote: > this._hasChildren = (type !== "symbol"); Done.
The CQ bit was checked by amikhaylova@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amikhaylova@google.com/337353002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by amikhaylova@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amikhaylova@google.com/337353002/40001
Message was sent while issue was closed.
Change committed as 176326 |
