Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 337353002: Object properties with values of Symbol type should not be expandable. (Closed)

Created:
6 years, 6 months ago by Alexandra Mikhaylova
Modified:
6 years, 6 months ago
Reviewers:
aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Object properties with values of Symbol type should not be expandable. BUG=376194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176326

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/sdk/RemoteObject.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Alexandra Mikhaylova
6 years, 6 months ago (2014-06-17 10:30:28 UTC) #1
aandrey
https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/components/ObjectPropertiesSection.js File Source/devtools/front_end/components/ObjectPropertiesSection.js (right): https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/components/ObjectPropertiesSection.js#newcode246 Source/devtools/front_end/components/ObjectPropertiesSection.js:246: this.hasChildren = this.property.value.hasChildren && !this.property.wasThrown && !(this.property.value.type === "symbol"); ...
6 years, 6 months ago (2014-06-17 10:36:34 UTC) #2
Alexandra Mikhaylova
On 2014/06/17 10:36:34, aandrey wrote: > https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/components/ObjectPropertiesSection.js > File Source/devtools/front_end/components/ObjectPropertiesSection.js (right): > > https://codereview.chromium.org/337353002/diff/1/Source/devtools/front_end/components/ObjectPropertiesSection.js#newcode246 > ...
6 years, 6 months ago (2014-06-17 10:57:54 UTC) #3
aandrey
On 2014/06/17 10:57:54, Alexandra Mikhaylova wrote: > On 2014/06/17 10:36:34, aandrey wrote: > > > ...
6 years, 6 months ago (2014-06-17 11:17:49 UTC) #4
Alexandra Mikhaylova
thanks, fixed this
6 years, 6 months ago (2014-06-17 12:24:15 UTC) #5
aandrey
lgtm https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_end/sdk/RemoteObject.js File Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_end/sdk/RemoteObject.js#newcode225 Source/devtools/front_end/sdk/RemoteObject.js:225: this._hasChildren = this._type === "symbol" ? false : ...
6 years, 6 months ago (2014-06-17 12:29:37 UTC) #6
Alexandra Mikhaylova
https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_end/sdk/RemoteObject.js File Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/337353002/diff/20001/Source/devtools/front_end/sdk/RemoteObject.js#newcode225 Source/devtools/front_end/sdk/RemoteObject.js:225: this._hasChildren = this._type === "symbol" ? false : true; ...
6 years, 6 months ago (2014-06-17 12:32:29 UTC) #7
Alexandra Mikhaylova
The CQ bit was checked by amikhaylova@google.com
6 years, 6 months ago (2014-06-17 12:35:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amikhaylova@google.com/337353002/40001
6 years, 6 months ago (2014-06-17 12:36:11 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 14:30:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18074)
6 years, 6 months ago (2014-06-17 14:30:56 UTC) #11
Alexandra Mikhaylova
The CQ bit was checked by amikhaylova@google.com
6 years, 6 months ago (2014-06-17 14:58:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amikhaylova@google.com/337353002/40001
6 years, 6 months ago (2014-06-17 14:59:11 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 16:04:57 UTC) #14
Message was sent while issue was closed.
Change committed as 176326

Powered by Google App Engine
This is Rietveld 408576698