Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2105)

Unified Diff: Source/devtools/front_end/sdk/RemoteObject.js

Issue 337353002: Object properties with values of Symbol type should not be expandable. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/Source/devtools/front_end/sdk/RemoteObject.js b/Source/devtools/front_end/sdk/RemoteObject.js
index b5b315ca0add2b50dccee60a00a30c8ae06859cc..16f6380317476a0d94e4f46224cb93c980371e0b 100644
--- a/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/Source/devtools/front_end/sdk/RemoteObject.js
@@ -222,7 +222,7 @@ WebInspector.RemoteObjectImpl = function(target, objectId, type, subtype, value,
// handle
this._objectId = objectId;
this._description = description;
- this._hasChildren = true;
+ this._hasChildren = (type !== "symbol");
this._preview = preview;
} else {
// Primitive or null object.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698