Source/bindings/tests/idls/TestObject.idl - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestObject.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/idls/TestObject.idl

diff --git a/Source/bindings/tests/idls/TestObject.idl b/Source/bindings/tests/idls/TestObject.idl

index 472101525165e084588f0ae0749bcfaba35a3b19..3ff233590e3b3d490c45130dbb2c6b754ac44250 100644

--- a/Source/bindings/tests/idls/TestObject.idl

+++ b/Source/bindings/tests/idls/TestObject.idl

@@ -410,6 +410,9 @@ interface TestObject {

void voidMethodDefaultNullableStringArg(optional DOMString? defaultStringArg = null);

void voidMethodDefaultNullableTestInterfaceArg(optional TestInterface? defaultTestInterfaceArg = null);

+ // Optional argument without default followed by optional argument with default

+ void voidMethodOptionalArgWithoutDefault(optional DOMString optionalStringArg, optional boolean defaultBooleanArg = false);

// Variadic operations

void voidMethodVariadicStringArg(DOMString... variadicStringArgs);

void voidMethodStringArgVariadicStringArg(DOMString stringArg, DOMString... variadicStringArgs);

@@ -451,10 +454,6 @@ interface TestObject {

// [Clamp]

void voidMethodClampUnsignedShortArg([Clamp] unsigned short clampUnsignedShortArg);

void voidMethodClampUnsignedLongArg([Clamp] unsigned long clampUnsignedLongArg);

- // [Default]

- void voidMethodDefaultUndefinedTestInterfaceEmptyArg([Default=Undefined] optional TestInterfaceEmpty defaultUndefinedTestInterfaceEmptyArg);

- void voidMethodDefaultUndefinedLongArg([Default=Undefined] optional long defaultUndefinedLongArg);

- void voidMethodDefaultUndefinedStringArg([Default=Undefined] optional DOMString defaultUndefinedStringArg);

// [EnforceRange]

void voidMethodEnforceRangeLongArg([EnforceRange] long enforceRangeLongArg);

// [TreatNullAs], [TreatUndefinedAs]