Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl - Issue 337343002: IDL: make optional arguments (without default) explicit sometimes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

diff --git a/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl b/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

index bc8a06bee84a75fc07fcaf32713d2ed59008e9e3..c1ead6fe899c4f6d27fcad3f817fd8ca2577a17d 100644

--- a/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

+++ b/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

@@ -30,9 +30,9 @@

ActiveDOMObject,

NamedConstructor=Audio(

DOMString stringArg,

- [Default=Undefined] optional boolean defaultUndefinedOptionalBooleanArg,

- [Default=Undefined] optional long defaultUndefinedOptionalLongArg,

- [Default=Undefined] optional DOMString defaultUndefinedOptionalStringArg,

+ optional boolean optionalBooleanArg,

+ optional long optionalLongArg,

+ optional DOMString optionalStringArg,

optional DOMString defaultNullStringOptionalstringArg = null,

optional DOMString optionalStringArg),

ConstructorCallWith=Document,

« no previous file with comments | « Source/bindings/tests/idls/TestInterfaceConstructor2.idl ('k') | Source/bindings/tests/idls/TestObject.idl » ('j') | no next file with comments »