Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: Source/bindings/tests/idls/TestInterfaceConstructor2.idl

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/idls/TestInterfaceConstructor2.idl
diff --git a/Source/bindings/tests/idls/TestInterfaceConstructor2.idl b/Source/bindings/tests/idls/TestInterfaceConstructor2.idl
index 10057de6dcce46770bf791f10f60f1fa9ba89864..b46834220741501f230dd77d512d78f6da568101 100644
--- a/Source/bindings/tests/idls/TestInterfaceConstructor2.idl
+++ b/Source/bindings/tests/idls/TestInterfaceConstructor2.idl
@@ -32,10 +32,6 @@
// Need separate tests for constructors with length == 0 and length > 0,
// and for overloaded vs. non-overloaded, if length > 0.
// length == 0, non-overloaded just omits a block and is not worth another test.
-//
-// Also includes some [Default] arguments (instead of in
-// TestInterfaceConstructor.idl), otherwise overload resolution check string is
-// extremely long and triggers a lint warning (line length).
[
// 2 constructors with same type length, to test overload resolution
Constructor(DOMString stringArg),
@@ -43,9 +39,9 @@
Constructor(
TestInterfaceEmpty testInterfaceEmptyArg,
long longArg,
- [Default=Undefined] optional DOMString defaultUndefinedOptionalStringArg,
+ optional DOMString defaultUndefinedOptionalStringArg,
optional DOMString defaultNullStringOptionalStringArg = null,
- [Default=Undefined] optional Dictionary defaultUndefinedOptionalDictionaryArg,
+ optional Dictionary defaultUndefinedOptionalDictionaryArg,
optional DOMString optionalStringArg),
] interface TestInterfaceConstructor2 {
};
« no previous file with comments | « Source/bindings/tests/idls/TestInterfaceConstructor.idl ('k') | Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698