Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp b/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp
index 940ba7c7a75f921a8453249049ac33aec40c712c..dd282198c7352d46ece16e12262f811336731951 100644
--- a/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp
@@ -78,7 +78,7 @@ void V8CanvasRenderingContext2D::strokeStyleAttributeSetterCustom(v8::Local<v8::
impl->setStrokeStyle(canvasStyle);
} else {
TOSTRING_VOID(V8StringResource<>, colorString, value);
- impl->setStrokeColor(colorString);
+ impl->setStrokeColor(colorString, makeOptionalMissing<float>());
}
}
@@ -95,7 +95,7 @@ void V8CanvasRenderingContext2D::fillStyleAttributeSetterCustom(v8::Local<v8::Va
impl->setFillStyle(canvasStyle);
} else {
TOSTRING_VOID(V8StringResource<>, colorString, value);
- impl->setFillColor(colorString);
+ impl->setFillColor(colorString, makeOptionalMissing<float>());
}
}
« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698