Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp

Issue 337343002: IDL: make optional arguments (without default) explicit sometimes Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-default-arguments-next
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 v8SetReturnValue(info, toV8Object(impl->strokeStyle(), info.Holder(), info.G etIsolate())); 71 v8SetReturnValue(info, toV8Object(impl->strokeStyle(), info.Holder(), info.G etIsolate()));
72 } 72 }
73 73
74 void V8CanvasRenderingContext2D::strokeStyleAttributeSetterCustom(v8::Local<v8:: Value> value, const v8::PropertyCallbackInfo<void>& info) 74 void V8CanvasRenderingContext2D::strokeStyleAttributeSetterCustom(v8::Local<v8:: Value> value, const v8::PropertyCallbackInfo<void>& info)
75 { 75 {
76 CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.H older()); 76 CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.H older());
77 if (RefPtrWillBeRawPtr<CanvasStyle> canvasStyle = toCanvasStyle(value, info. GetIsolate())) { 77 if (RefPtrWillBeRawPtr<CanvasStyle> canvasStyle = toCanvasStyle(value, info. GetIsolate())) {
78 impl->setStrokeStyle(canvasStyle); 78 impl->setStrokeStyle(canvasStyle);
79 } else { 79 } else {
80 TOSTRING_VOID(V8StringResource<>, colorString, value); 80 TOSTRING_VOID(V8StringResource<>, colorString, value);
81 impl->setStrokeColor(colorString); 81 impl->setStrokeColor(colorString, makeOptionalMissing<float>());
82 } 82 }
83 } 83 }
84 84
85 void V8CanvasRenderingContext2D::fillStyleAttributeGetterCustom(const v8::Proper tyCallbackInfo<v8::Value>& info) 85 void V8CanvasRenderingContext2D::fillStyleAttributeGetterCustom(const v8::Proper tyCallbackInfo<v8::Value>& info)
86 { 86 {
87 CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.H older()); 87 CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.H older());
88 v8SetReturnValue(info, toV8Object(impl->fillStyle(), info.Holder(), info.Get Isolate())); 88 v8SetReturnValue(info, toV8Object(impl->fillStyle(), info.Holder(), info.Get Isolate()));
89 } 89 }
90 90
91 void V8CanvasRenderingContext2D::fillStyleAttributeSetterCustom(v8::Local<v8::Va lue> value, const v8::PropertyCallbackInfo<void>& info) 91 void V8CanvasRenderingContext2D::fillStyleAttributeSetterCustom(v8::Local<v8::Va lue> value, const v8::PropertyCallbackInfo<void>& info)
92 { 92 {
93 CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.H older()); 93 CanvasRenderingContext2D* impl = V8CanvasRenderingContext2D::toNative(info.H older());
94 if (RefPtrWillBeRawPtr<CanvasStyle> canvasStyle = toCanvasStyle(value, info. GetIsolate())) { 94 if (RefPtrWillBeRawPtr<CanvasStyle> canvasStyle = toCanvasStyle(value, info. GetIsolate())) {
95 impl->setFillStyle(canvasStyle); 95 impl->setFillStyle(canvasStyle);
96 } else { 96 } else {
97 TOSTRING_VOID(V8StringResource<>, colorString, value); 97 TOSTRING_VOID(V8StringResource<>, colorString, value);
98 impl->setFillColor(colorString); 98 impl->setFillColor(colorString, makeOptionalMissing<float>());
99 } 99 }
100 } 100 }
101 101
102 } // namespace blink 102 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8ScriptRunner.cpp ('k') | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698