Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 337263007: Make ChromeSigninClient check if the passed in process id is valid (Closed)

Created:
6 years, 5 months ago by Devlin
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ChromeSigninClient check if the passed in process id is valid ChromeSigninClient::IsSigninProcess() checks only if the passed in process is equal to the signin host id, but the signin host id is initialized to -1 (and set back if the signin process goes away). This means that if we ever check if an invalid process is a signin process, the answer is "yes". Fix this by making ChromeSigninClient::IsSigninProcess check if the process id is valid first. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/signin/chrome_signin_client.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Devlin
6 years, 5 months ago (2014-06-27 00:03:37 UTC) #1
Andrew T Wilson (Slow)
lgtm
6 years, 5 months ago (2014-06-27 05:58:44 UTC) #2
Andrew T Wilson (Slow)
Added Roger as a reviewer since I think he knows this code better than I ...
6 years, 5 months ago (2014-06-27 05:59:39 UTC) #3
Devlin
Roger, friendly ping?
6 years, 5 months ago (2014-06-30 15:57:12 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm Sorry for delay.
6 years, 5 months ago (2014-06-30 18:26:38 UTC) #5
Devlin
On 2014/06/30 18:26:38, Roger Tawa wrote: > Sorry for delay. No worries :) Thanks for ...
6 years, 5 months ago (2014-06-30 18:38:18 UTC) #6
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 5 months ago (2014-06-30 18:38:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/337263007/1
6 years, 5 months ago (2014-06-30 18:39:12 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 20:50:06 UTC) #9
Message was sent while issue was closed.
Change committed as 280658

Powered by Google App Engine
This is Rietveld 408576698