chrome/browser/signin/chrome_signin_client.cc - Issue 337263007: Make ChromeSigninClient check if the passed in process id is valid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/chrome_signin_client.cc

Issue 337263007: Make ChromeSigninClient check if the passed in process id is valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/signin/chrome_signin_client.cc

diff --git a/chrome/browser/signin/chrome_signin_client.cc b/chrome/browser/signin/chrome_signin_client.cc

index 29a63551be3db5d2232a99e0a7de0d3ed8073535..3238a1affee070531cf781e31875926cef182b19 100644

--- a/chrome/browser/signin/chrome_signin_client.cc

+++ b/chrome/browser/signin/chrome_signin_client.cc

@@ -79,7 +79,8 @@ void ChromeSigninClient::ClearSigninProcess() {

}

bool ChromeSigninClient::IsSigninProcess(int process_id) const {

- return process_id == signin_host_id_;

+ return process_id != ChildProcessHost::kInvalidUniqueID &&

+ process_id == signin_host_id_;

}

bool ChromeSigninClient::HasSigninProcess() const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »