[DevTools] Tracing handler keeps running even after devtools frontend has been closed.

[DevTools] Tracing handler keeps running even after devtools frontend has been closed.

This is happening as the tracing handler is not listening to the frontend close events.
When the front-end is closed, the tracing handler is unaware of it and it keeps collecting the data.
With the active frontend close, the tracing handler should invoke DisableRecording to stop processing further.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278681

[vivekg, 2014-06-19 11:55:32]

PTAL, thank you.

[yurys, 2014-06-19 14:03:04]

Instead of listening to AgentState changes which we are going to remove lets
introduce OnCliendDetached method on DevToolsTracingHandler and have it called
from RenderViewDevToolsAgentHost::OnClientDetached like we already do with
overrides handler. We should do the same with DevToolsPowerHandler.

[vivekg, 2014-06-19 14:06:08]

On 2014/06/19 14:03:04, yurys wrote:
> Instead of listening to AgentState changes which we are going to remove lets
> introduce OnCliendDetached method on DevToolsTracingHandler and have it called
> from RenderViewDevToolsAgentHost::OnClientDetached like we already do with
> overrides handler. We should do the same with DevToolsPowerHandler.

Sure, would update the patch accordingly. Thanks for the review. :)

[vivekg, 2014-06-19 14:51:26]

Done, PTAL.

[yurys, 2014-06-20 06:21:02]

LGTM. Thanks!

[vivekg, 2014-06-20 06:21:54]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-06-20 06:24:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/337213005/20001

[commit-bot: I haz the power, 2014-06-20 11:10:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-20 12:04:38]

Change committed as 278681