Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: content/browser/devtools/devtools_tracing_handler.h

Issue 337213005: [DevTools] Tracing handler keeps running even after devtools frontend has been closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments updated! Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_tracing_handler.h
diff --git a/content/browser/devtools/devtools_tracing_handler.h b/content/browser/devtools/devtools_tracing_handler.h
index c41f1ec9791d65587d28aacf8d95fbfdeced3f1d..787a123f666e57a708f7601bdaa86c4a2c5e4dd9 100644
--- a/content/browser/devtools/devtools_tracing_handler.h
+++ b/content/browser/devtools/devtools_tracing_handler.h
@@ -24,6 +24,8 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {
explicit DevToolsTracingHandler(Target target);
virtual ~DevToolsTracingHandler();
+ void OnClientDetached();
+
private:
void BeginReadingRecordingResult(const base::FilePath& path);
void ReadRecordingResult(const scoped_refptr<base::RefCountedString>& result);
@@ -38,6 +40,10 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {
TracingController::Options TraceOptionsFromString(const std::string& options);
+ void DisableRecording(
+ const TracingController::TracingFileResultCallback& callback =
+ TracingController::TracingFileResultCallback());
+
base::WeakPtrFactory<DevToolsTracingHandler> weak_factory_;
scoped_ptr<base::Timer> buffer_usage_poll_timer_;
Target target_;
« no previous file with comments | « no previous file | content/browser/devtools/devtools_tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698