Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: net/spdy/spdy_http_utils.h

Issue 337093003: QuicServer: Use Chrome's header parsing rather than Balsa (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@quic_server_3
Patch Set: (mark StringPieceUtils as copied, not added) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_http_utils.h
diff --git a/net/spdy/spdy_http_utils.h b/net/spdy/spdy_http_utils.h
index d15b6c7a873febb66a095b2bf242493528161ab8..d2ddaac072c880c4a6937e4ab4a68ed2f87abeb1 100644
--- a/net/spdy/spdy_http_utils.h
+++ b/net/spdy/spdy_http_utils.h
@@ -7,6 +7,7 @@
#include "net/base/net_export.h"
#include "net/base/request_priority.h"
+#include "net/http/http_response_headers.h"
#include "net/spdy/spdy_framer.h"
#include "net/spdy/spdy_header_block.h"
#include "net/spdy/spdy_protocol.h"
@@ -28,6 +29,13 @@ bool SpdyHeadersToHttpResponse(const SpdyHeaderBlock& headers,
HttpResponseInfo* response);
// Create a SpdyHeaderBlock for a Spdy SYN_STREAM Frame from
Ryan Hamilton 2014/06/19 00:15:44 I suspect this is actually for a SYN_REPLY since t
dmz 2014/06/19 21:17:02 Ah, yes.
+// HttpResponseHeaders.
+void NET_EXPORT_PRIVATE CreateSpdyHeadersFromHttpResponse(
+ scoped_refptr<HttpResponseHeaders> response_headers,
+ SpdyHeaderBlock* headers,
+ SpdyMajorVersion protocol_version);
Ryan Hamilton 2014/06/19 00:15:44 In-params should come before out-params.
dmz 2014/06/19 21:17:03 I was imitating CreateSpdyHeadersFromHttpRequest.
Ryan Hamilton 2014/06/20 00:24:09 Doh! yeah, that'd be great, thanks.
dmziegler 2014/06/20 01:16:40 Done.
+
+// Create a SpdyHeaderBlock for a Spdy SYN_STREAM Frame from
Ryan Hamilton 2014/06/19 00:15:44 SYN_STREAM is *so* SPDY/3. All the cool kids used
dmz 2014/06/19 21:17:02 Haha, done.
// HttpRequestInfo and HttpRequestHeaders.
void NET_EXPORT_PRIVATE CreateSpdyHeadersFromHttpRequest(
const HttpRequestInfo& info,

Powered by Google App Engine
This is Rietveld 408576698