QuicServer: Use Chrome's header parsing rather than Balsa

net/spdy/spdy_http_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_HTTP_UTILS_H_
 #define NET_SPDY_SPDY_HTTP_UTILS_H_
 
 #include "net/base/net_export.h"
 #include "net/base/request_priority.h"
+#include "net/http/http_response_headers.h"
 #include "net/spdy/spdy_framer.h"
 #include "net/spdy/spdy_header_block.h"
 #include "net/spdy/spdy_protocol.h"
 #include "url/gurl.h"
 
 namespace net {
 
 class HttpResponseInfo;
 struct HttpRequestInfo;
 class HttpRequestHeaders;
 
 // Convert a SpdyHeaderBlock into an HttpResponseInfo.
 // |headers| input parameter with the SpdyHeaderBlock.
 // |response| output parameter for the HttpResponseInfo.
 // Returns true if successfully converted.  False if the SpdyHeaderBlock is
 // incomplete (e.g. missing 'status' or 'version').
 bool SpdyHeadersToHttpResponse(const SpdyHeaderBlock& headers,
                                SpdyMajorVersion protocol_version,
                                HttpResponseInfo* response);
 
 // Create a SpdyHeaderBlock for a Spdy SYN_STREAM Frame from

[Ryan Hamilton, 2014/06/19 00:15:44]

I suspect this is actually for a SYN_REPLY since this is a response. But same
comment as below about SYN_STREAM being un-cool :>

[dmz, 2014/06/19 21:17:02]

Ah, yes.

+// HttpResponseHeaders.
+void NET_EXPORT_PRIVATE CreateSpdyHeadersFromHttpResponse(
+    scoped_refptr<HttpResponseHeaders> response_headers,
+    SpdyHeaderBlock* headers,
+    SpdyMajorVersion protocol_version);

[Ryan Hamilton, 2014/06/19 00:15:44]

In-params should come before out-params.

[dmz, 2014/06/19 21:17:03]

I was imitating CreateSpdyHeadersFromHttpRequest. Do you want me to change both?

[Ryan Hamilton, 2014/06/20 00:24:09]

Doh! yeah, that'd be great, thanks.

[dmziegler, 2014/06/20 01:16:40]

Done.

+
+// Create a SpdyHeaderBlock for a Spdy SYN_STREAM Frame from

[Ryan Hamilton, 2014/06/19 00:15:44]

SYN_STREAM is *so* SPDY/3. All the cool kids used HEADERS_WITH_PRIORITY. That
being said, I might be inclined to drop the "for a Spdy ... frame" from this
comment.

[dmz, 2014/06/19 21:17:02]

Haha, done.

 // HttpRequestInfo and HttpRequestHeaders.
 void NET_EXPORT_PRIVATE CreateSpdyHeadersFromHttpRequest(
     const HttpRequestInfo& info,
     const HttpRequestHeaders& request_headers,
     SpdyHeaderBlock* headers,
     SpdyMajorVersion protocol_version,
     bool direct);
 
 // Returns the URL associated with the |headers| by assembling the
 // scheme, host and path from the protocol specific keys.
 NET_EXPORT_PRIVATE GURL GetUrlFromHeaderBlock(const SpdyHeaderBlock& headers,
                                               SpdyMajorVersion protocol_version,
                                               bool pushed);
 
 NET_EXPORT_PRIVATE SpdyPriority ConvertRequestPriorityToSpdyPriority(
     RequestPriority priority,
     SpdyMajorVersion protocol_version);
 
 NET_EXPORT_PRIVATE RequestPriority ConvertSpdyPriorityToRequestPriority(
     SpdyPriority priority,
     SpdyMajorVersion protocol_version);
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_HTTP_UTILS_H_