Mac: implement drag-and-drop of URLs to tabs/tab strip.

chrome/browser/cocoa/browser_window_controller.h

Index: chrome/browser/cocoa/browser_window_controller.h
diff --git a/chrome/browser/cocoa/browser_window_controller.h b/chrome/browser/cocoa/browser_window_controller.h
index 68cbb82b11cf874aa49b0437de2db47bd4325286..72fa734e740f7c3acae10b6c1031cb74f09243c9 100644
--- a/chrome/browser/cocoa/browser_window_controller.h
+++ b/chrome/browser/cocoa/browser_window_controller.h
@@ -18,6 +18,7 @@
 #import "chrome/browser/cocoa/bookmark_bar_controller.h"
 #import "chrome/browser/cocoa/bookmark_bubble_controller.h"
 #import "chrome/browser/cocoa/browser_command_executor.h"
+#import "chrome/browser/cocoa/url_drop_target.h"
 #import "chrome/browser/cocoa/view_resizer.h"
 #include "chrome/browser/sync/sync_ui_util.h"
 #import "third_party/GTM/AppKit/GTMTheme.h"
@@ -47,7 +48,8 @@ class TabStripModelObserverBridge;
                       BookmarkBarControllerDelegate,
                       BrowserCommandExecutor,
                       ViewResizer,
-                      GTMThemeDelegate> {
+                      GTMThemeDelegate,
+                      URLDropTargetWindowController> {

[pink (ping after 24hrs), 2009/12/07 15:42:02]

crud, i wish i had seen this before you checked it in. The way this should be
done is not with yet another protocol, but by dispatching the call through the
responder chain and catching it at the BWC. That'll prevent us from having to
plumb it all the way down the line when nothing in the middle cares.

That's how I was going to do it before I got side-tracked to other things. We
should probably do with with loading of urls clicked on the bookmark bar as well
(it's basically the same issue).

[viettrungluu, 2009/12/07 15:52:21]

I had a previous version which passed it down the responder chain -- it didn't
work so well, at least not without taking fairly heroic efforts. The problem is
that you often drag to an inactive window, which isn't on the responder chain at
all. So you'd have to catch it in the app controller (in addition to in the BWC,
since the window *might* be active), which then has to figure out which window
to send it to. So in the end the app controller would have to look up the
browser window controller anyway.

(If it's any consolation, I don't add yet another delegate to go stale; I just
look up the controller from its window....)

  @private
   // The ordering of these members is important as it determines the order in
   // which they are destroyed. |browser_| needs to be destroyed last as most of
@@ -183,6 +185,12 @@ class TabStripModelObserverBridge;
 // tab's sheet queue.
 - (void)removeConstrainedWindow:(ConstrainedWindowMac*)window;
 
+// Implementation of the |URLDropTargetWindowController| protocol, which is
+// needed for URL dropping on the tab strip.
+- (void)dropURLs:(NSArray*)urls at:(NSPoint)location;
+- (void)indicateDropURLsAt:(NSPoint)location;
+- (void)hideDropURLsIndicator;
+
 @end
 
 // Methods which are either only for testing, or only public for testing.