Mac: implement drag-and-drop of URLs to tabs/tab strip.

chrome/browser/cocoa/browser_window_controller.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 #define CHROME_BROWSER_COCOA_BROWSER_WINDOW_CONTROLLER_H_
 
 // A class acting as the Objective-C controller for the Browser
 // object. Handles interactions between Cocoa and the cross-platform
 // code. Each window has a single toolbar and, by virtue of being a
 // TabWindowController, a tab strip along the top.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/scoped_nsobject.h"
 #include "base/scoped_ptr.h"
 #import "chrome/browser/cocoa/tab_window_controller.h"
 #import "chrome/browser/cocoa/bookmark_bar_controller.h"
 #import "chrome/browser/cocoa/bookmark_bubble_controller.h"
 #import "chrome/browser/cocoa/browser_command_executor.h"
+#import "chrome/browser/cocoa/url_drop_target.h"
 #import "chrome/browser/cocoa/view_resizer.h"
 #include "chrome/browser/sync/sync_ui_util.h"
 #import "third_party/GTM/AppKit/GTMTheme.h"
 
 class Browser;
 class BrowserWindow;
 class BrowserWindowCocoa;
 @class ChromeBrowserWindow;
 class ConstrainedWindowMac;
 @class DownloadShelfController;
 @class ExtensionShelfController;
 @class FindBarCocoaController;
 @class GTMWindowSheetController;
 @class InfoBarContainerController;
 class LocationBar;
 class StatusBubbleMac;
 class TabContents;
 @class TabContentsController;
 @class TabStripController;
 class TabStripModelObserverBridge;
 @class TabStripView;
 @class ToolbarController;
 @class TitlebarController;
 
 @interface BrowserWindowController :
   TabWindowController<NSUserInterfaceValidations,
                       BookmarkBarControllerDelegate,
                       BrowserCommandExecutor,
                       ViewResizer,
-                      GTMThemeDelegate> {
+                      GTMThemeDelegate,
+                      URLDropTargetWindowController> {

[pink (ping after 24hrs), 2009/12/07 15:42:02]

crud, i wish i had seen this before you checked it in. The way this should be
done is not with yet another protocol, but by dispatching the call through the
responder chain and catching it at the BWC. That'll prevent us from having to
plumb it all the way down the line when nothing in the middle cares.

That's how I was going to do it before I got side-tracked to other things. We
should probably do with with loading of urls clicked on the bookmark bar as well
(it's basically the same issue).

[viettrungluu, 2009/12/07 15:52:21]

I had a previous version which passed it down the responder chain -- it didn't
work so well, at least not without taking fairly heroic efforts. The problem is
that you often drag to an inactive window, which isn't on the responder chain at
all. So you'd have to catch it in the app controller (in addition to in the BWC,
since the window *might* be active), which then has to figure out which window
to send it to. So in the end the app controller would have to look up the
browser window controller anyway.

(If it's any consolation, I don't add yet another delegate to go stale; I just
look up the controller from its window....)

  @private
   // The ordering of these members is important as it determines the order in
   // which they are destroyed. |browser_| needs to be destroyed last as most of
   // the other objects hold weak references to it or things it owns
   // (tab/toolbar/bookmark models, profiles, etc).
   scoped_ptr<Browser> browser_;
   NSWindow* savedRegularWindow_;
   scoped_ptr<TabStripModelObserverBridge> tabObserver_;
   scoped_ptr<BrowserWindowCocoa> windowShim_;
   scoped_nsobject<ToolbarController> toolbarController_;
@@ skipping 115 matching lines @@
 // Returns YES if the window became the active per-tab sheet of the current tab,
 // or NO if the current tab already has a per-tab sheet. If this returns NO,
 // the window's |Realize()| method will be called again when the curren sheet
 // disappears. The window should then call |attachConstrainedWindow:| again.
 - (BOOL)attachConstrainedWindow:(ConstrainedWindowMac*)window;
 
 // Closes the tab sheet |window| and potentially shows the next sheet in the
 // tab's sheet queue.
 - (void)removeConstrainedWindow:(ConstrainedWindowMac*)window;
 
+// Implementation of the |URLDropTargetWindowController| protocol, which is
+// needed for URL dropping on the tab strip.
+- (void)dropURLs:(NSArray*)urls at:(NSPoint)location;
+- (void)indicateDropURLsAt:(NSPoint)location;
+- (void)hideDropURLsIndicator;
+
 @end
 
 // Methods which are either only for testing, or only public for testing.
 @interface BrowserWindowController(TestingAPI)
 
 // Put the incognito badge on the browser and adjust the tab strip
 // accordingly.
 - (void)installIncognitoBadge;
 
 // Allows us to initWithBrowser withOUT taking ownership of the browser.
@@ skipping 15 matching lines @@
 // Return a point suitable for the topLeft for a bookmark bubble.
 - (NSPoint)topLeftForBubble;
 
 // Resets any saved state about window growth (due to showing the bookmark bar
 // or the download shelf), so that future shrinking will occur from the bottom.
 - (void)resetWindowGrowthState;
 
 @end  // BrowserWindowController(TestingAPI)
 
 #endif  // CHROME_BROWSER_COCOA_BROWSER_WINDOW_CONTROLLER_H_